Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiscoveredPackage entries missing package detection info #1099

Closed
AyanSinhaMahapatra opened this issue Mar 4, 2024 · 0 comments
Closed

DiscoveredPackage entries missing package detection info #1099

AyanSinhaMahapatra opened this issue Mar 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@AyanSinhaMahapatra
Copy link
Member

In SCTK Package model (Package Instance, detected in a codebase, created out of Package metadata and it's files) has the following fields:

  • datafile_paths (List of paths for the package metadata for this package instance)
  • datasource_ids (List of Datasource Ids for the respective package metadata)

But in SCIO DiscoveredPackage model, we only have:

  • datasource_id

As a result of the mismatch, during DiscoveredPackage creation/update from PackageData fields, we were losing these data fields and were displaying a blank Datasource IDs field in the Package View -> Others Tab.

For example: scanning celery-5.2.7 with a scan_single_package pipeline, we would get the following in the package view:

celery-no-datasource-ids
@AyanSinhaMahapatra AyanSinhaMahapatra added the bug Something isn't working label Mar 4, 2024
AyanSinhaMahapatra added a commit that referenced this issue Mar 4, 2024
@AyanSinhaMahapatra
Fix package detection info in DiscoveredPackages #1099
edd0896 
Reference: #1099
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this issue Mar 4, 2024
Merged
tdruez pushed a commit that referenced this issue Mar 25, 2024
@AyanSinhaMahapatra
Fix package detection info in DiscoveredPackages #1099 (#1100)
56de573 
* Fix package detection info in DiscoveredPackages #1099

Reference: #1099
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>

* Add package detection info in the UI

* Adds package detection info in the package details view
* Adds data migration for datasource_id

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>

* Add changelog entry and address feedback

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>

---------

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@tdruez tdruez closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tdruez @AyanSinhaMahapatra