Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the ProjectError model to a more global ProjectMessage #338 #338

Closed
tdruez opened this issue Oct 7, 2021 · 3 comments
Closed

Migrate the ProjectError model to a more global ProjectMessage #338 #338

tdruez opened this issue Oct 7, 2021 · 3 comments

Comments

@tdruez
Copy link
Member

tdruez commented Oct 7, 2021

Those Project issues are not particularly useful and there's often too much of those.
It has the bad effect of hiding more important errors that happened during pipeline runs.

Screenshot 2021-10-07 at 9 58 57 AM

@pombredanne any good reasons to keep creating those?

@pombredanne
Copy link
Member

  • Not creating these as packages may mean we skip on useful things.
  • The error messages are problematic.
  • IMHO we should have something that would be some way to provide a warning: here is a Windows executable and we do not have full information on its origin and license. You should look into this

@tdruez
Copy link
Member Author

tdruez commented Oct 7, 2021

Not creating these as packages may mean we skip on useful things.

They cannot be created as packages (only resources) at the DB level since those are missing mandatory fields...

@pombredanne
Copy link
Member

Packages that are incomplete can or cannot be created (may be they could) when they are missing some key fields BUT in all cases these are warnings and not errors. I suggest these updates

  • rename the ProjectError model to ProjectMessage
  • add a "severity" field to each error as a choice of "error", "warning", "info".
  • the packages that are missing some key fields should de tagged as "warning" rather than error.
  • we could display the counters of info/warning/messages rather than only errors.
  • later, we could have a way to resolve errors with a new "resolution" field that would store a resolution note when the error is resolved. For instance this kind of error:
ERROR: for scanner: licenses: ERROR: Processing interrupted: timeout after 120 seconds. 	
id: 21457001
md5: 43e47161986663a8d308c08907c21931
name: TestListSkus
path: azure-sdk-for-net-64c6c3b957bd22fb0664bb3b7500c046aaa87ddc.zip-extract/azure-sdk-for-net-64c6c3b957bd22fb0664bb3b7500c046aaa87ddc/sdk/compute/Microsoft.Azure.Management.Compute/tests/SessionRecords/ListSkuTests/TestListSkus.json

could be resolved automatically as "not important" as this is a large (15MB) JSON data files that times out, adn is further a test file.

Also it would be useful to:

  • keep a link to the corresponding Resource(s) or Package to help with the investigation.
  • always create these packages even if not complete or missing some key information

There also bugs and improvement issues to have fewer errors and messages:

@tdruez tdruez changed the title Turn off "One or more of the required fields have no value" errors Migrate the ProjectError model to are more global ProjectMessage Jul 12, 2023
@tdruez tdruez changed the title Migrate the ProjectError model to are more global ProjectMessage Migrate the ProjectError model to a more global ProjectMessage #338 Jul 12, 2023
tdruez added a commit that referenced this issue Jul 12, 2023
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Jul 12, 2023
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Jul 26, 2023
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Aug 24, 2023
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Aug 24, 2023
Signed-off-by: Thomas Druez <tdruez@nexb.com>
@tdruez tdruez closed this as completed Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants