Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List views UI improvements #506

Closed
3 tasks done
tdruez opened this issue Aug 18, 2022 · 0 comments
Closed
3 tasks done

List views UI improvements #506

tdruez opened this issue Aug 18, 2022 · 0 comments
Assignees
@tdruez

Comments

@tdruez
Copy link
Member

tdruez commented Aug 18, 2022 •
edited

@tdruez tdruez self-assigned this Aug 18, 2022
tdruez added a commit that referenced this issue Aug 18, 2022
@tdruez
Add ability to sort by column in resource list view #506
c210e0c 
Using a reusable TableColumnsMixin

Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Aug 19, 2022
@tdruez
Add ability to sort by column in package and error list views #506
86c7a1c 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Aug 19, 2022
@tdruez
Set the table_columns system on the Project list view #506
61010f0 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Aug 19, 2022
@tdruez
Fix an encoding in rendering options of filters when data is empty #506
6d504e1 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Aug 22, 2022
@tdruez
Add ability to sort by Project counts in list view #506
366e459 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Aug 22, 2022
@tdruez
List views UI improvements #506 (#508)
e390aea 
* Add ability to sort by column in resource list view #506

Using a reusable TableColumnsMixin

Signed-off-by: Thomas Druez <tdruez@nexb.com>

* Add ability to sort by column in package and error list views #506

Signed-off-by: Thomas Druez <tdruez@nexb.com>

* Set the table_columns system on the Project list view #506

Signed-off-by: Thomas Druez <tdruez@nexb.com>

* Fix an encoding in rendering options of filters when data is empty #506

Signed-off-by: Thomas Druez <tdruez@nexb.com>

* Add ability to sort by Project counts in list view #506

Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Aug 24, 2022
@tdruez
Add ability to sort by Project counts in list view #506
94ba1ce 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Aug 25, 2022
@tdruez
Rewrite ProjectQuerySet.with_counts with Subquery for performances #506
9bdd94f 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Aug 29, 2022
@tdruez
Add HTML title for list views #506
25fc3e9 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Aug 31, 2022
@JonoYang @tdruez
Implement DiscoveredDependency model (#486)
6c26874 
* Implement package assembly in scancode.io #447

Signed-off-by: Jono Yang <jyang@nexb.com>

* Minor formatting changes for consistency #447

Signed-off-by: Thomas Druez <tdruez@nexb.com>

* Create DiscoveredPackages before other models #447

Signed-off-by: Jono Yang <jyang@nexb.com>

* Revert "Create DiscoveredPackages before other models #447"

This reverts commit c9b8bed.

Sorting Packages, Dependencies, and Resources from DatafileHandler.assemble() will never work. The code needs to be changed in scancode-toolkit.

Signed-off-by: Jono Yang <jyang@nexb.com>

* Update migration #444

Signed-off-by: Jono Yang <jyang@nexb.com>

* Return package_uids in for_packages #444

    * This is so we are consistent with scancode-toolkit JSON output
    * Update expected test results

Signed-off-by: Jono Yang <jyang@nexb.com>

* Create directory Resources in docker pipeline #485

    * Update test expectations

Signed-off-by: Jono Yang <jyang@nexb.com>

* Implement package assembly in scancode.io #447

Signed-off-by: Jono Yang <jyang@nexb.com>

* Implement package assembly in scancode.io #447

Signed-off-by: Jono Yang <jyang@nexb.com>

* Create DiscoveredDependency model #447

    * Create new dependency list and detail views
    * Update assemble_packages() to create DiscoveredDependencies
    * Update test expectations

Signed-off-by: Jono Yang <jyang@nexb.com>

* Update fields on DiscoveredDependency #447

    * Remove for_package_uid and replace with ForeignKey for_package
    * Remove datafile_path and replace with ForeignKey datafile_resource
    * Create properties for the two removed fields
    * Update dependency views to link to datafile_resource
    * Update expected test results

Signed-off-by: Jono Yang <jyang@nexb.com>

* Properly pluralize verbose name #447

Signed-off-by: Jono Yang <jyang@nexb.com>

* Create new argument for create_from_data #447

    * Add strip_datafile_path_root to DiscoveredDependency.create_from_data
    * This argument strips the root path segment from `datafile_path` before using the path to look up the corresponding CodebaseResource
    * This is used in the case where we are importing a scan from scancode-toolkit, where the root path segments are not stripped by default
    * Update expected test results

Signed-off-by: Jono Yang <jyang@nexb.com>

* Update prefetch_related #447

    * Used cached_property for DiscoveredDependency properties

Signed-off-by: Jono Yang <jyang@nexb.com>

* Prefetch related models in output code #447

Signed-off-by: Jono Yang <jyang@nexb.com>

* Import scancode.io 30.2.0 scans in load_codebase

    * Order DiscoveredDependencies by is_runtime, is_optional, is_resolved, and dependency_uid
    * Do not show dependency_uid value in DiscoveredDependency list view

Signed-off-by: Jono Yang <jyang@nexb.com>

* Revert changes for importing old scancode.io scans

Signed-off-by: Jono Yang <jyang@nexb.com>

* Regen migrations for DiscoveredDependency #447

Signed-off-by: Jono Yang <jyang@nexb.com>

* Migrate DiscoveredPackage.dependencies #447

    * Create migrations to generate new DiscoveredDependency objects from DiscoveredPackage.dependencies before removing the dependencies field

Signed-off-by: Jono Yang <jyang@nexb.com>

* Update test expectations #447

Signed-off-by: Jono Yang <jyang@nexb.com>

* Remove accidentally committed files #447

Signed-off-by: Jono Yang <jyang@nexb.com>

* Update migration logic #447

    * Remove unnecessary else from DiscoveredDependency properties

Signed-off-by: Jono Yang <jyang@nexb.com>

* Add PackageURLMixin to DiscoveredDependency #447

Signed-off-by: Jono Yang <jyang@nexb.com>

* Set DiscoveredDependencies purl fields #447

    * Create migration that populates purl fields for existing DiscoveredDependencies

Signed-off-by: Jono Yang <jyang@nexb.com>

* Store purl values in purl fields #447

    * Do not store dependency_uid in purl fields

Signed-off-by: Jono Yang <jyang@nexb.com>

* Remove purl field from DiscoveredDependency #447

    * We are already storing this info in the purl fields
    * Create purl property on DiscoveredDependency for compatibility

Signed-off-by: Jono Yang <jyang@nexb.com>

* Update DependencyFilterSet #447

    * Add search and purl fields

Signed-off-by: Jono Yang <jyang@nexb.com>

* Don't show DiscoveredDependencies purl fields #447

Signed-off-by: Jono Yang <jyang@nexb.com>

* Update package detail view dependencies tab #447

Signed-off-by: Jono Yang <jyang@nexb.com>

* Add package_type to dependency serializer #511

    * Update test expectations

Signed-off-by: Jono Yang <jyang@nexb.com>

* Update expected test results

Signed-off-by: Jono Yang <jyang@nexb.com>

* Add dependency table column #447

Signed-off-by: Jono Yang <jyang@nexb.com>

* Use tabset in dependency detail view #447

    * Add package_type property to DiscoveredDependency

Signed-off-by: Jono Yang <jyang@nexb.com>

* Update dependency list view #447

    * Use updated table header include
    * Update dependency presentation in package detail view
    * Show package uid on hover on for package tab

Signed-off-by: Jono Yang <jyang@nexb.com>

* Set DiscoveredDependency serializer fields #511

    * Update DiscoveredDependency ordering

Signed-off-by: Jono Yang <jyang@nexb.com>

* Create donut chart for package type #447

Signed-off-by: Jono Yang <jyang@nexb.com>

* Consolidate migrations #447

    * Update DiscoveredDependency ordering
    * Update daglib test expectations

Signed-off-by: Jono Yang <jyang@nexb.com>

* Update dependency JSON ordering #447

    * Update test expectations

Signed-off-by: Jono Yang <jyang@nexb.com>

* Set proper discovereddependencies related_name #447

Signed-off-by: Thomas Druez <tdruez@nexb.com>

* Fix template indentation #447

Signed-off-by: Thomas Druez <tdruez@nexb.com>

* Refactor update_from_data method into a UpdateFromDataMixin #447

Signed-off-by: Thomas Druez <tdruez@nexb.com>

* Fix the ProjectSerializer fields #447

Signed-off-by: Thomas Druez <tdruez@nexb.com>

* Fix test_scanpipe_api_project_detail unit test #447

Signed-off-by: Thomas Druez <tdruez@nexb.com>

* Add HTML title for list views #506

Signed-off-by: Thomas Druez <tdruez@nexb.com>

* Update dependency tabs #447

    * Only show links in dependency for_package tab or dependency datafile_resource tab if there is a value

Signed-off-by: Jono Yang <jyang@nexb.com>

* Use UpdateFromDataMixin #447

    * Use UpdateFromDataMixin in DiscoveredDependency
    * Create test for DiscoveredDependency.update_from_data()

Signed-off-by: Jono Yang <jyang@nexb.com>

* Fix formatting #447

Signed-off-by: Thomas Druez <tdruez@nexb.com>

Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Thomas Druez <tdruez@nexb.com>
Co-authored-by: Thomas Druez <tdruez@nexb.com>
@tdruez tdruez closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdruez tdruez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tdruez