-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker-compose.yml #1133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to add a service, in the main compose config file, that is only required for a very specific use-case.
I would suggest to have a new compose file dedicated to this.
https://docs.docker.com/compose/multiple-compose-files/
@tdruez I've reverted the docker-compose files I modified and created a new docker-compose.purldb-scan-queue-worker.yml for this. |
@JonoYang There must be a better way than duplicating the whole compose file for a few line additions. Can't we use the "merge", "extend", "include", features of compose? https://docs.docker.com/compose/multiple-compose-files/ What about a simpler filename
|
* Add new service for package-scan-worker Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
49c9c25
to
447b6ad
Compare
* Update docker-compose for purldb scan worker to include docker-compose.yml, rather than copy the contents * Update CHANGELOG.rst Signed-off-by: Jono Yang <jyang@nexb.com>
447b6ad
to
9642433
Compare
@tdruez I've renamed the |
This PR add a new service in the
docker-compose.yml
files to run thepurldb-scan-queue-worker
command.