Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fingerprint codebase resources #1163

Merged
merged 9 commits into from
Apr 18, 2024
Merged

Fingerprint codebase resources #1163

merged 9 commits into from
Apr 18, 2024

Conversation

JonoYang
Copy link
Contributor

This PR adds the function scanpipe.pipes.matchcode.fingerprint_codebase_resources(), which computes approximate file matching fingerprints for text files using the new get_file_fingerprint_hashes function from matchcode-toolkit.

Related PR: aboutcode-org/matchcode-toolkit#6

@JonoYang JonoYang force-pushed the fingerprint-codebase-resources branch 2 times, most recently from b7b85ab to a1bc8aa Compare April 16, 2024 19:58
@JonoYang JonoYang requested a review from tdruez April 16, 2024 20:00
@JonoYang JonoYang marked this pull request as ready for review April 16, 2024 20:00
Copy link
Member

@tdruez tdruez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonoYang Looks good to me, just a single comment to address and ready for merge :)

scanpipe/pipes/matchcode.py Outdated Show resolved Hide resolved
Signed-off-by: Jono Yang <jyang@nexb.com>
    * Use specific matchcode-toolkit branch in setup.cfg

Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
@JonoYang JonoYang force-pushed the fingerprint-codebase-resources branch from 081ff30 to 7dda493 Compare April 17, 2024 17:28
@tdruez tdruez merged commit 310d0a8 into main Apr 18, 2024
9 checks passed
@tdruez tdruez deleted the fingerprint-codebase-resources branch April 18, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants