Add D2D for ELFs and Go binaries #1113 #1114 #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
changed the title
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
tdruez
requested changes
Apr 22, 2024
scanpipe/pipes/d2d.py
Outdated
| @@ -1662,3 +1664,148 @@ def _match_purldb_resources_post_process( | |||
| package.add_resources(unmapped_resources) | |||
|
|
|||
| return interesting_codebase_resources.count() | |||
|
|
|||
|
|
|||
| def _map_paths_resource( | |||
There was a problem hiding this comment.
Too much imbrications, please refactor in smaller testable pieces.
scanpipe/pipes/d2d.py
Outdated
| from_resources.get(id=rid) for rid in match.resource_ids | ||
| ] | ||
| matched_from_resources.sort( | ||
| key=lambda res: (len(res.path.strip("/").split("/")), res.path) |
There was a problem hiding this comment.
A proper well-named function would be better for readability and testing.
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
pombredanne
changed the title
pombredanne
reviewed
Apr 23, 2024
| @@ -189,6 +191,16 @@ def map_javascript(self): | |||
| """ | |||
| d2d.map_javascript(project=self.project, logger=self.log) | |||
|
|
|||
| @group("Elf") | |||
| def map_elf(self): | |||
| """Map DWARF paths using similarities of path suffixes.""" | |||
There was a problem hiding this comment.
Suggested change
| """Map DWARF paths using similarities of path suffixes.""" | |
| """Map ELF binaries to their sources.""" |
tdruez
requested changes
Apr 23, 2024
scanpipe/pipes/d2d.py
Outdated
| ) | ||
|
|
||
|
|
||
| def process_relations( |
There was a problem hiding this comment.
This function name and the docstring are too generic.
scanpipe/pipes/d2d.py
Outdated
| """ | ||
| return sorted( | ||
| matched_from_resources, | ||
| key=lambda res: (len(res.path.strip("/").split("/")), res.path), |
There was a problem hiding this comment.
That's the lambda "key" that needed to be replaced by a function.
pombredanne
reviewed
Apr 23, 2024
|
|
||
| @group("Go") | ||
| def map_go(self): | ||
| """Map GO file paths using similarities of path suffixes.""" |
There was a problem hiding this comment.
Suggested change
| """Map GO file paths using similarities of path suffixes.""" | |
| """Map Go binaries to their sources.""" |
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for these two issues:
Testing steps:
toside of the D2D, by addingto-prefix on the zip file. For exampleto-data.zipand add the files likebuilder.goin a zip file and add it to thefromside of the D2D, by addingfrom-prefix on the zip file.map_deploy_to_developpipeline.