Populate package and dependency attributes in inspect_packages #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdruez
requested changes
Apr 25, 2024
AyanSinhaMahapatra
force-pushed
the
fix-inspect-packages
branch
from
034c7fd
to
aa420b1
Compare
AyanSinhaMahapatra
changed the title
Properly populate dependency attributes like for_package, datasource_id and datafile_resource for DiscoveredDependencies and codebase_resources in DiscoveredPackages found in inspect_packages pipeline. Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
fix-inspect-packages
branch
from
aa420b1
to
479c3e3
Compare
tdruez
requested changes
Apr 29, 2024
mjherzog
changed the title
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly populate dependency attributes like for_package, datasource_id and datafile_resource for DiscoveredDependencies found in inspect_packages pipeline.
Also populate datasource_ids and codebase_resources correctly for packages.
Here we only assign to the package the codebase resource of the package manifest where it was found, as assigning all other package resources would require a full package assembly, and thus out of scope for this pipeline.