Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a ScanForVirus Pipeline #1182 #1193

Merged
merged 8 commits into from
May 30, 2024
Merged

Implement a ScanForVirus Pipeline #1182 #1193

merged 8 commits into from
May 30, 2024

Conversation

tdruez
Copy link
Contributor

@tdruez tdruez commented Apr 30, 2024

No description provided.

Copy link
Contributor

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks decent... what's the hold to merge?

@tdruez
Copy link
Contributor Author

tdruez commented May 27, 2024

what's the hold to merge?

The structure is there, we now have to handle the output from ClamAV and store that data in the db.

@tdruez tdruez marked this pull request as ready for review May 29, 2024 14:53
@pombredanne
Copy link
Contributor

The structure is there, we now have to handle the output from ClamAV and store that data in the db.

@tdruez I would store this in extra_data at first.

@pombredanne
Copy link
Contributor

... And/or report an error message if there is a virus detected?

Copy link
Contributor

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thanks.

Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez tdruez merged commit 1fb34ad into main May 30, 2024
9 checks passed
@tdruez tdruez deleted the 1182-scan-for-virus branch May 30, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants