Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update rootfs to scan resource path #840

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

philcali
Copy link
Contributor

@philcali philcali commented Aug 1, 2023

When uploading an exported Linux rootfs archive, the current rootfs included the extracted root directory, which broke linking files from installed packages, (ie: rpms.sqlite). This change fixes that.

@pombredanne
Copy link
Member

Thanks!
Do you mind you amend your commit with a DCS signoff?

@philcali
Copy link
Contributor Author

philcali commented Aug 2, 2023

Will do. I also broke an integration test as well. I'll update it.

When uploading an exported Linux rootfs archive, the current rootfs included the extracted root directory, which broke linking files from installed packages, (ie: rpms.sqlite). This change fixes that.

Signed-off-by: Philip Cali <philip.cali@gmail.com>
Signed-off-by: Philip Cali <philip.cali@gmail.com>
@philcali philcali force-pushed the fix-rootfs-installed-file-path branch from 79a5853 to 2dd4249 Compare August 3, 2023 00:17
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great!
Thanks.
I submitted philcali#1 so you get the latest main and we would need a simple CHANGELOG entry here to merge this PR

Merge main branch from upstream scancode.io
Signed-off-by: Philip Cali <philip.cali@gmail.com>
@philcali philcali force-pushed the fix-rootfs-installed-file-path branch from 034aa6f to 5eb9259 Compare August 7, 2023 13:17
@philcali
Copy link
Contributor Author

philcali commented Aug 7, 2023

Thank you! Changelog entry was added.

@tdruez tdruez merged commit 2f5a6cc into nexB:main Aug 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants