Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI to validate code style #54

Open
pombredanne opened this issue Feb 15, 2022 · 2 comments
Open

Add CI to validate code style #54

pombredanne opened this issue Feb 15, 2022 · 2 comments

Comments

@pombredanne
Copy link
Member

And also run black on all the code including etc
keshav-space added a commit to keshav-space/univers that referenced this issue Feb 15, 2022
@keshav-space
don't test docs and etc
5fc4c36 
- codestyle test for `etc`, will be handled by `skeleton`
- see: nexB/skeleton#54

Signed-off-by: keshav-space <keshav6240@gmail.com>
@keshav-space keshav-space mentioned this issue Feb 15, 2022
Merged
@keshav-space
Copy link
Member

So @pombredanne we need to have black in setup.cfg

skeleton/setup.cfg

Lines 38 to 41 in 4004ebe

[options.extras_require]
testing =
pytest >= 6, != 7.0.0
pytest-xdist >= 2

And a test_skeleton_codestyle.py under tests/
Is that good enough?

@pombredanne
Copy link
Member Author

@keshav-space

we need to have black in setup.cfg

Yes!

And a test_skeleton_codestyle.py under tests/ Is that good enough?

The skeleton being a template, we have to think a minute about the tests... They will be merged in repos using the skeleton... and at the same we want them to run on the skeleton proper.
Therefore test_skeleton_codestyle.py or some other name must be designed to be unique across all projects.
This looks like a good conspicuous and unique name, so go for it!
👍

keshav-space added a commit to keshav-space/skeleton that referenced this issue Feb 22, 2022
@keshav-space
Add black codestyle test for skeleton
840ccef 
- see nexB#54

Signed-off-by: keshav-space <keshav6240@gmail.com>
@keshav-space keshav-space mentioned this issue Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pombredanne @keshav-space