Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the tracecode command and path match work #2

Merged
merged 63 commits into from Dec 10, 2019
Merged

Make the tracecode command and path match work #2

merged 63 commits into from Dec 10, 2019

Conversation

licodeli
Copy link
Contributor

First step to make the tracecode work and the match feature work

Li added 4 commits October 10, 2019 21:27
Add the command to support tracecode scan and add test case #1
1091fca 
Signed-off-by: Li <li@nexb.com>
Include necessary libraries, include trace code #1
bac020e 
Signed-off-by: Li <li@nexb.com>
Add the compare feature #1
511636e 
Signed-off-by: Li <li@nexb.com>
Make the first match work #1
241f4a5 
Signed-off-by: Li <li@nexb.com>
@pombredanne
Copy link
Member

@linexb thank you!

Li added 4 commits October 30, 2019 22:41
Refine the variable name and imports #1
ae7b2fe 
Signed-off-by: Li <li@nexb.com>
Remove useless imports #1
f3e47ed 
Signed-off-by: Li <li@nexb.com>
Remove useless modules and code #1
94ae3e5 
Signed-off-by: Li <li@nexb.com>
Comment word refinement #1
106f663 
Signed-off-by: Li <li@nexb.com>
@licodeli
Copy link
Contributor Author

@pombredanne I have done some refinement job like cleaning up the useless code, imports etc. Please review. :)

Li and others added 20 commits November 3, 2019 07:18
Add more est cases #1
dfb100c 
Signed-off-by: Li <li@nexb.com>
Add the test case when json input is not existing #1
daa4c6f 
Signed-off-by: Li <li@nexb.com>
Add the test when the input is not a json file #1
b0ddf87 
Signed-off-by: Li <li@nexb.com>
@pombredanne
Rename tracecode.tracecode to tracecode.matchers #1
6b33210 
This is better than a name repetition.
Move the TraceCode object to matcher and rename as DeploymentAnalysis
Also perform minor formatting

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Add tests for pathutils from original tracecode #1
2b3b9bc 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Format code #1
3997468 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Group test files by test #1
e04007a 
This grouping makes it easier to read through test files and data

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Use matchers.DeploymentAnalysis in command line #!
29e50f5 
Also applied minor code refinements and formatting

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Suppress Click unicode warnings #1
d2032ad 
These will be void when we only support Python 3

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Make develop ahead of deploy argument #1
45a2a54 
Signed-off-by: Li <li@nexb.com>
Add VirtualCodebase from scancode #2
d3e87ed 
Signed-off-by: Li <li@nexb.com>
Make the json format working by reading from scancode #2
4949a00 
Signed-off-by: Li <li@nexb.com>
Make the function simple #2
51bc129 
Signed-off-by: Li <li@nexb.com>
Refine is_json_path function to parse with simplejson instead of judg…
9fd8893 
…ing with the file name #1

Signed-off-by: Li <li@nexb.com>
Format the code #1
10a5688 
Signed-off-by: Li <li@nexb.com>
Include deployed_to, match and confidence related to match #3
256b675 
Signed-off-by: Li <li@nexb.com>
Add proper comments #1
3d92443 
Signed-off-by: Li <li@nexb.com>
Format the code #1
21d9db0 
Signed-off-by: Li <li@nexb.com>
Abstract the constant instead of string #3
7148194 
Signed-off-by: Li <li@nexb.com>
To match the file with suffix #3
943365c 
Signed-off-by: Li <li@nexb.com>
Li added 9 commits November 22, 2019 20:37
Remove useless code and add more test #1
e210e64 
Signed-off-by: Li <li@nexb.com>
Add more test case #1
3299f8d 
Signed-off-by: Li <li@nexb.com>
Use function to abstract the shared code #3
79ecf3b 
Signed-off-by: Li <li@nexb.com>
Use or relationship instead of long code #3
8c47ce3 
Signed-off-by: Li <li@nexb.com>
Format the code and refine the comment #1
87af030 
Signed-off-by: Li <li@nexb.com>
Reorg test cases #1
5c7f258 
Signed-off-by: Li <li@nexb.com>
Reine the test case #3
d9724e6 
Signed-off-by: Li <li@nexb.com>
Remove useless code and imports #3
04ca081 
Signed-off-by: Li <li@nexb.com>
Update the name of the app #1
34cd06b 
Signed-off-by: Li <li@nexb.com>
Li added 9 commits November 28, 2019 22:29
Avoid sha1 and md5 match run the same time #3
bdc1674 
Signed-off-by: Li <li@nexb.com>
Fix the test error #1
a0d402e 
Signed-off-by: Li <li@nexb.com>
Make checksum match available only when path match exists too #3
41c9af2 
Signed-off-by: Li <li@nexb.com>
Use attr instead of constructor #3
523ae8b 
Signed-off-by: Li <li@nexb.com>
Refine variable and make develop as a base #3
64ca38c 
Signed-off-by: Li <li@nexb.com>
Correct README file #1
6368ed2 
Signed-off-by: Li <li@nexb.com>
Refine the variable name #1
b2f476c 
Signed-off-by: Li <li@nexb.com>
Make the index dict's value as a list #3
b2449b4 
Signed-off-by: Li <li@nexb.com>
Adjust develop and deploy order #1
c9d223f 
Signed-off-by: Li <li@nexb.com>
@pombredanne
Copy link
Member

Tell me when this is ready to review

Li added 7 commits December 4, 2019 11:03
Refine the code #1
c3fcfe1 
Signed-off-by: Li <li@nexb.com>
Add more test for get_checksum_index_sha1 function #1
a0c3c7b 
Signed-off-by: Li <li@nexb.com>
Format the import #1
f4afd49 
Signed-off-by: Li <li@nexb.com>
Reorg the import #1
6602b55 
Signed-off-by: Li <li@nexb.com>
Refine the code #1
2e656c2 
Signed-off-by: Li <li@nexb.com>
Format the code #1
31da400 
Signed-off-by: Li <li@nexb.com>
Remove duplicate code #1
10a1273 
Signed-off-by: Li <li@nexb.com>
pombredanne
pombredanne approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! thanks. Merging

@pombredanne pombredanne merged commit 2c85bc8 into develop Dec 10, 2019
@pombredanne pombredanne deleted the 1-basic-command branch December 10, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@licodeli @pombredanne