Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor gem and make nuget hashable #75

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Refactor gem and make nuget hashable #75

merged 2 commits into from
Apr 11, 2023

Conversation

keshav-space
Copy link
Member

pombredanne
pombredanne requested changes Jul 26, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks... See my review comments. Please keep segments and canonical_segments as tuples, e.g. the new property should return a tuple() not a generator.

src/univers/gem.py Show resolved Hide resolved
src/univers/gem.py Show resolved Hide resolved
src/univers/gem.py Outdated Show resolved Hide resolved
src/univers/gem.py Outdated Show resolved Hide resolved
@keshav-space keshav-space mentioned this pull request Aug 2, 2022
Draft
pombredanne
pombredanne approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@keshav-space
Refactor GemVersion
08959e2 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
Make nuget version hashable
19de006 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@TG1999 TG1999 merged commit 205da7e into nexB:main Apr 11, 2023
@keshav-space keshav-space deleted the refactor_gem branch April 11, 2023 19:02
keshav-space pushed a commit that referenced this pull request Aug 30, 2023
@AyanSinhaMahapatra
Bump github actions versions #75
5be7a24 
Update the following actions:

* actions/checkout
* actions/setup-python

Reference: nexB/skeleton#75
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
keshav-space pushed a commit that referenced this pull request Aug 30, 2023
@AyanSinhaMahapatra
Merge pull request #78 from nexB/update-github-actions
30f3f02 
Bump github actions versions #75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

@TG1999 TG1999 Awaiting requested review from TG1999

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@keshav-space @pombredanne @TG1999