Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vulntotal #1009

Merged
merged 46 commits into from
Nov 21, 2022
Merged

Add Vulntotal #1009

merged 46 commits into from
Nov 21, 2022

Conversation

pombredanne
Copy link
Member

@pombredanne pombredanne commented Nov 19, 2022 •
edited
Loading

This PR is for vulntotal

I also applied a few refinements:

  • use smaller test files for snyk
  • mark network tests as such. Also use a faster NuGet endpoint
  • various minor refactoring
  • use standard license notice headers

Ready for your review

@keshav-space
add initial config for vulntotal
303efca 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
Merge pull request #777 from keshav-space/vulntotal_init
cfcdfd7 
add initial config for vulntotal
@keshav-space
don't include raw_dump in VendorData
2176cb1 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
add supported ecosystem
922859f 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
drop Validator in favour of DataSource
78dd5ae 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
adopt new CLI
fe20e49 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
add Deps Datasource
e30131f 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
add tests for Deps Datasource
3235316 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
add Github Datasource
1724d91 
- closes: #791

Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
add vulntotal utils
8d42af1 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
add tests for Github Datasource
d1c7d17 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
add OSS-Index Datasource
4a62daa 
- closes: #820

Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
add tests for OSS-Index Datasource
e639b5e 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
add VulnerableCode DataSource
03fc9b0 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
add Snyk Datasource
7b1faf8 
- closes: #834

Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
add vulntotal utils
13328c7 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
add Gitlab Datasource
9a38cf2 
- closes: #836

Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
add vulntotal utils
0378b6c 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
test Gitlab Datasource
55fc8a8 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
register available datasources
edf2d61 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
add osv DataSource
1fa44ce 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
support get_closest_nuget_package_name
ab161ff 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
test OSVDataSource
491c318 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
add utilities for vulntotal
536dd91 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
pombredanne and others added 4 commits November 19, 2022 09:08
@pombredanne
Merge branch 'deps-only' into vulntotal-clean
1a0744d
@pombredanne
Merge keshav-space:github_validator
97c2f79 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Merge remote-tracking branch 'keshav-space/oss_index_datasource' into…
b18b2ed 
… vulntotal-clean
@keshav-space @pombredanne
test snyk Datasource
ec64fc9 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
pombredanne and others added 16 commits November 19, 2022 09:23
@pombredanne
Merge keshav-space:snyk_datasource branch
edc4047 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Merge keshav-space:gitlab_datasource branch
3664c3e 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@keshav-space @pombredanne
test VulnerableCodeDataSource
fb7ef75 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@pombredanne
Merge branch 'vulnerablecode_datasource' into vulntotal-clean
50d38db
@pombredanne
Merge remote-tracking branch 'keshav-space/vulntotal_cli' into vulnto…
cad9501 
…tal-clean
@pombredanne
Merge remote-tracking branch 'keshav-space/datasource_registry' into …
7af1b5d 
…vulntotal-clean
@pombredanne
Use explicit list of datasources
1cb8ead 
This is better, safer and simpler than a discovered list

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Use standard header and streamline imports
5033af7 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Use simpler and smaller test fixtures
9a559bf 
* Do not use files for short lists
* Use smaller and discrete test files
* Prefer indivisual tests using plain HTML rather than packing data in
  JSON

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Streamline CLI help
557728f 
Also add CLI to console scripts

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Do not use file for small test data list
76908fc 
Instead inline the data for improved readability

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Remove unused file
07553e4 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Streamline code
4980f92 
Use variables when relevant

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Use faster Nuget API
575cc19 
Also refactor tests

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Add webtest marker to test making network call
d69b4e5 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Remove unused imports
e54618d 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This was referenced Nov 19, 2022
Closed
Closed
Closed
@pombredanne
Merge remote-tracking branch 'origin/main' into vulntotal
6e77b25
@pombredanne
Format code
6d838e6 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@keshav-space
Copy link
Member

LGTM 👍

TG1999
TG1999 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pombredanne pombredanne merged commit bf49673 into main Nov 21, 2022
@pombredanne pombredanne deleted the vulntotal branch November 21, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TG1999 TG1999 TG1999 approved these changes

@keshav-space keshav-space keshav-space approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pombredanne @keshav-space @TG1999