Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest npm data through github api #1025 #1027

Merged
merged 2 commits into from
Dec 28, 2022
Merged

Conversation

TG1999
Copy link
Member

@TG1999 TG1999 commented Dec 5, 2022

Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

@TG1999 TG1999 changed the title Ingest npm data through github api Ingest npm data through github api #1025 Dec 5, 2022
@TG1999 TG1999 linked an issue Dec 7, 2022 that may be closed by this pull request
@pombredanne pombredanne added this to the v32.0.0 milestone Dec 8, 2022
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks... See a few comments inline

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you ++

@pombredanne pombredanne merged commit 92d1bf0 into nexB:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable NPM support in Github importer
2 participants