Varnish v4.1.10+ ban request not working Error Unable to detect varnish version

[ngongoll]

all ban request will end with error Unable to detect varnish version when subversion of varnish 4.1 has 2 digits.

you can fix it by change the line 91 in
app/code/community/Nexcessnet/Turpentine/Model/Varnish/Admin/Socket.php
to

const REGEXP_VARNISH_VERSION = '/^varnish-(?P\d).(?P\d).(?P\d{1,2}) revision (?P[0-9a-f]+)$/';

[notimplementedyet]

i wouldn't change it that way.
who tells you there will be no two digit minor version or three digit version sub?

if limiting the numbers i would go for something like this:
const REGEXP_VARNISH_VERSION = '/^varnish-(?P\d{1,2}).(?P\d{1,3}).(?P\d{1,2}) revision (?P[0-9a-f]+)$/;

but my prefered regex would just be just not limiting the numbers:
const REGEXP_VARNISH_VERSION = '/^varnish-(?P\d+).(?P\d+).(?P\d+) revision (?P[0-9a-f]+)$/;

[sprankhub]

Are you sure this works @ngongoll? Later, after the preg_match, the vmajor and vminor group is referenced, which you deleted:

magento-turpentine/app/code/community/Nexcessnet/Turpentine/Model/Varnish/Admin/Socket.php

Lines 373 to 374 in e948e9f

	} elseif (preg_match(self::REGEXP_VARNISH_VERSION, $bannerText[4], $matches) === 1) {
	return $matches['vmajor'].'.'.$matches['vminor'];

Update: It may work, but _determineVersion does not return the correct Varnish version in this case.

Besides of that, would you mind creating a pull request?

[notimplementedyet]

created a pull request #1491

[Flyingmana]

(comment out of the off:) Could please someone do a follow up PullRequest refactoring this to not use a regex anymore? PHP has perfectly fine functions to compare versions, which are easier to read and change then a regex.

[dunkla]

Any updates on this?

[dunkla]

at the cost of repeating myself: any updates on this?

[miguelbalparda]

This should be fixed in devel by #1491, care to check?

[dunkla]

Looks good to me.