fix: look for .git dir in parents of input dir #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2 changed the git command used by next-build-id from using the
-C
flag to using the--git-dir
and--work-tree
flags, which are more strict in the sense that if the directory path given does not exist, git will fail, whereas the-C
flag will work for any subdirectory within a git project.Unfortunately the test suite for next-build-id was not smart enough to accurately mimic this git behavior, so the problem was unknown until I started using an upgraded version of this lib.
This PR fixes that regression by:
.git
dir (if it exists) before calling the git command--git-dir
path does not exist