add --group-add

nexdrew · May 21, 2020 · 4b2937d · 4b2937d
1 parent 3475490
commit 4b2937d
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -194,6 +194,7 @@ array.forEach((r) => {
 | `HostConfig.UTSMode`         | `--uts`          |
 | `HostConfig.RestartPolicy`   | `--restart`      |
 | `HostConfig.ExtraHosts`      | `--add-host`     |
+| `HostConfig.GroupAdd`        | `--group-add`    |
 | `HostConfig.PidMode`         | `--pid`          |
 | `HostConfig.SecurityOpt`     | `--security-opt` |
 | `Config.Hostname`            | `-h`             |

diff --git a/index.js b/index.js
@@ -125,7 +125,7 @@ function toRunCommand (inspectObj, name) {
     })
   }
   if (isCompatible('--add-host', modes)) rc = appendArray(rc, '--add-host', hostcfg.ExtraHosts)
-  // TODO hostcfg.GroupAdd
+  rc = appendArray(rc, '--group-add', hostcfg.GroupAdd)
   if (hostcfg.PidMode) rc = append(rc, '--pid', hostcfg.PidMode)
   rc = appendArray(rc, '--security-opt', hostcfg.SecurityOpt, quote)
 

diff --git a/test/fixtures/inspect-one-two.json b/test/fixtures/inspect-one-two.json
@@ -284,7 +284,11 @@
       "DnsOptions": [],
       "DnsSearch": [],
       "ExtraHosts": null,
-      "GroupAdd": null,
+      "GroupAdd": [
+        "audio",
+        "nogroup",
+        "777"
+      ],
       "IpcMode": "",
       "Cgroup": "",
       "Links": null,

diff --git a/test/test-cli.js b/test/test-cli.js
@@ -66,6 +66,7 @@ const expectedOneTwo = '\n' +
   '--runtime nvidia ' +
   '--volumes-from admiring_brown --volumes-from silly_jang ' +
   '--restart no ' +
+  '--group-add audio --group-add nogroup --group-add 777 ' +
   '-h 46d567b2ef86 ' +
   '--domainname rekcod.xyz ' +
   '-e \'PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\' ' +