-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More flexiable nexe footer search range to fix digital sign binary fail to launch issue #600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@foxever this is great, thank you! I just have some small style/naming nits and I'll merge.
It will be a while before they're available though through github releases. Log of builds here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm going to kick this around a bit before I merge it to master, with the non-windows OSes
Update: merged
I am still experiencing #372 after signing my Windows binary, even with nexe v3.1.0. Is there anything special I need to do to get this to work? Any particular build flags I need to use? EDIT: It seems that if I use |
@lange That is correct. The prebuilds haven't been updated yet. I'm hoping to get them running soon but don't have an eta at the moment. |
@calebboyd Got it, makes total sense, thanks for clarifying! I shall wait patiently and use |
Please confirm here when they are updated!! Thank you!! |
Are you still planning to update the prebuilds? Our CI system spends an extra 25minutes multiple times a day due to the --build flag :) Do you think we can create local prebuilds for ourself somehow? Thanks a lot! |
@calebboyd sorry that I keep pinging here. I'm really desperate about getting prebuilds for v3.0.3+. |
What version are you needing? |
@calebboyd I need 10.15.3 😄 |
@calebboyd I'd need 10.12.0. Thanks a lot! |
Builds incoming. They'll populate over the next few days |
@calebboyd Will the new builds appear here? https://github.com/nexe/nexe/releases |
Fix Windows binary break after digital sign.
Prebuilt binary still works with this approach.
Credit to @tamasszarka #372 (comment)