Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexiable nexe footer search range to fix digital sign binary fail to launch issue #600

Closed
wants to merge 3 commits into from

Conversation

foxever
Copy link
Contributor

@foxever foxever commented Apr 2, 2019

Fix Windows binary break after digital sign.
Prebuilt binary still works with this approach.
Credit to @tamasszarka #372 (comment)

Copy link
Member

@calebboyd calebboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foxever this is great, thank you! I just have some small style/naming nits and I'll merge.

It will be a while before they're available though through github releases. Log of builds here...

src/patches/boot-nexe.ts Outdated Show resolved Hide resolved
src/patches/boot-nexe.ts Outdated Show resolved Hide resolved
src/patches/boot-nexe.ts Outdated Show resolved Hide resolved
src/patches/boot-nexe.ts Outdated Show resolved Hide resolved
Copy link
Member

@calebboyd calebboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'm going to kick this around a bit before I merge it to master, with the non-windows OSes

Update: merged

@calebboyd calebboyd closed this Apr 4, 2019
@Abrahamic-God
Copy link

Abrahamic-God commented Apr 14, 2019

I am still experiencing #372 after signing my Windows binary, even with nexe v3.1.0. Is there anything special I need to do to get this to work? Any particular build flags I need to use?

EDIT: It seems that if I use --build, it works. My guess is that new prebuilds have yet to be created since this PR was merged? Are there plans to provide updated prebuilds in the near future?

@calebboyd
Copy link
Member

@lange That is correct. The prebuilds haven't been updated yet. I'm hoping to get them running soon but don't have an eta at the moment.

@Abrahamic-God
Copy link

@calebboyd Got it, makes total sense, thanks for clarifying! I shall wait patiently and use --build in the meantime.

@ricardopolo
Copy link

Please confirm here when they are updated!! Thank you!!

@tamasszarka
Copy link

Are you still planning to update the prebuilds? Our CI system spends an extra 25minutes multiple times a day due to the --build flag :) Do you think we can create local prebuilds for ourself somehow? Thanks a lot!

@tamasszarka
Copy link

@calebboyd sorry that I keep pinging here. I'm really desperate about getting prebuilds for v3.0.3+.
I'd be more than happy to help generating the official ones too, if you provide some guidance. Can you help me?

@calebboyd
Copy link
Member

What version are you needing?

@ricardopolo
Copy link

@calebboyd I need 10.15.3 😄

@tamasszarka
Copy link

@calebboyd I'd need 10.12.0. Thanks a lot!

@calebboyd
Copy link
Member

Builds incoming. They'll populate over the next few days

@tamasszarka
Copy link

@calebboyd Will the new builds appear here? https://github.com/nexe/nexe/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants