use phpstan's strict rules

nexendrie · Dec 1, 2017 · 451db16 · 451db16
1 parent 0407b15
commit 451db16
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -4,4 +4,5 @@
 composer.lock		export-ignore
 phpstan.neon    	export-ignore
 .scrutinizer.yml	export-ignore
-build.xml           export-ignore
+build.xml           export-ignore
+phpstan.neon        export-ignore
diff --git a/build.xml b/build.xml
@@ -56,7 +56,7 @@
       <arg value="-l"/>
       <arg value="7"/>
       <arg value="-c"/>
-      <arg path="vendor/nexendrie/code-quality/phpstan.neon"/>
+      <arg path="phpstan.neon"/>
       <arg path="src"/>
       <arg path="tests"/>
     </exec>

diff --git a/phpstan.neon b/phpstan.neon
@@ -0,0 +1,3 @@
+includes:
+    - vendor/nexendrie/code-quality/phpstan.neon
+    - vendor/phpstan/phpstan-strict-rules/rules.neon
diff --git a/src/Generator.php b/src/Generator.php
@@ -124,13 +124,13 @@ public function generate(): \SimpleXMLElement {
     }
     $channel = simplexml_load_file(__DIR__ . "/template.xml");
     $channel->channel->lastBuildDate[0][0] = date($this->dateTimeFormat, $lastBuildDate);
-    if($this->link) {
+    if($this->link !== "") {
       $channel->channel->link[0][0] = $this->link;
     }
-    if($this->title) {
+    if($this->title !== "") {
       $channel->channel->title[0][0] = $this->title;
     }
-    if($this->description) {
+    if($this->description !== "") {
       $channel->channel->description[0][0] = $this->description;
     }
     /** @var RssChannelItem $item */