Support for in-memory and temporary sqlite databases #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for those in memory and temporary modes in sqlite. Recently I have encountered some problems while trying to deploy and test my website on docker and on DigitalOcean App cloud. My website uses library remix-image which then uses hybrid-disk-cache under the hood.
First problems occured when I wanted to run only temporary (or fully in-memory) db for testing purposes on my local machine, or test same setup on cloud app with very restricted filesystem permissions where I wanted to keep database in-memory or in specified directory while at the same time forward files to other volume.
In this PR I was able to maintain backward compatibility so all earlier tests are green, no breaking changes, I just expanded the interface by adding new property
dbPath