Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in voxelize_hits paolina function when only 1 hit is present #328

Closed
paolafer opened this issue Sep 6, 2017 · 2 comments
Closed

Crash in voxelize_hits paolina function when only 1 hit is present #328

paolafer opened this issue Sep 6, 2017 · 2 comments

Comments

@paolafer
Copy link
Collaborator

paolafer commented Sep 6, 2017

I've realized that the function voxelize_hits in paolina_functions gives an error when the collection of hits is composed of just 1 item. This happens because the calculated boundaries are the same and the number of bins is zero. However, the correct behaviour should be that one voxel be built, so the number of bins be 1.
@jacg
Copy link
Collaborator

jacg commented Sep 6, 2017

Please add a test to paolina_functions_test.py detailing your expectations. Start a PR with that test in it.
Once that's in place, someone (possibly me, if I have the time) can make it pass.

@jacg jacg mentioned this issue Sep 6, 2017
Merged
@jacg
Copy link
Collaborator

jacg commented Sep 6, 2017

This is addressed in #329.

@jacg jacg closed this as completed in aa3ca94 Sep 8, 2017
jacg pushed a commit that referenced this issue Sep 8, 2017
Deal with 1 hit in voxelize_hits
7817404 
Closes #328

Previously, the code was crashing when a hit collection contained only
one item.
jacg added a commit that referenced this issue Sep 9, 2017
@jacg
Ensure that at least one bin is required
8755da5 
Fixes #328.
jacg added a commit that referenced this issue Sep 9, 2017
@jacg
Deal with 1 hit in voxelize_hits
ba45a8b 
Closes #328

Previously, the code was crashing when a hit collection contained only
one item.
jacg added a commit that referenced this issue Sep 9, 2017
@jacg
Ensure that at least one bin is required
7958ae8 
Fixes #328.
jacg added a commit that referenced this issue Sep 9, 2017
@jacg
Deal with 1 hit in voxelize_hits
79a7890 
Closes #328

Previously, the code was crashing when a hit collection contained only
one item.
jacg added a commit that referenced this issue Sep 9, 2017
@jacg
Ensure that at least one bin is required
947e01f 
Fixes #328.
jacg added a commit that referenced this issue Sep 9, 2017
@jacg
Deal with 1 hit in voxelize_hits
1e9aec8 
Closes #328

Previously, the code was crashing when a hit collection contained only
one item.
jacg added a commit that referenced this issue Sep 10, 2017
@jacg
Ensure that at least one bin is required
c913991 
Fixes #328.
jacg added a commit that referenced this issue Sep 10, 2017
@jacg
Deal with 1 hit in voxelize_hits
74a6354 
Closes #328

Previously, the code was crashing when a hit collection contained only
one item.
jacg added a commit that referenced this issue Sep 15, 2017
@jacg
Ensure that at least one bin is required
bde8ff0 
Fixes #328.
jacg added a commit that referenced this issue Sep 15, 2017
@jacg
Deal with 1 hit in voxelize_hits
ac2bcac 
Closes #328

Previously, the code was crashing when a hit collection contained only
one item.
jmbenlloch pushed a commit to jmbenlloch/IC-1 that referenced this issue Apr 24, 2018
@jacg
Ensure that at least one bin is required
9a7459a 
Fixes next-exp#328.
jmbenlloch pushed a commit to jmbenlloch/IC-1 that referenced this issue Apr 24, 2018
@jacg
Deal with 1 hit in voxelize_hits
3cc9a8d 
Closes next-exp#328

Previously, the code was crashing when a hit collection contained only
one item.
jacg added a commit to jacg/IC that referenced this issue Sep 14, 2018
@jacg
Ensure that at least one bin is required
242e6cf 
Fixes next-exp#328.
jacg added a commit to jacg/IC that referenced this issue Sep 14, 2018
@jacg
Deal with 1 hit in voxelize_hits
ff16d8e 
Closes next-exp#328

Previously, the code was crashing when a hit collection contained only
one item.
jmbenlloch pushed a commit to jmbenlloch/IC-1 that referenced this issue Oct 16, 2018
@jacg
Ensure that at least one bin is required
b0be9d5 
Fixes next-exp#328.
jmbenlloch pushed a commit to jmbenlloch/IC-1 that referenced this issue Oct 16, 2018
@jacg
Deal with 1 hit in voxelize_hits
5feb567 
Closes next-exp#328

Previously, the code was crashing when a hit collection contained only
one item.
jmbenlloch pushed a commit to jmbenlloch/IC-1 that referenced this issue Oct 16, 2018
@jacg
Ensure that at least one bin is required
7abf036 
Fixes next-exp#328.
jmbenlloch pushed a commit to jmbenlloch/IC-1 that referenced this issue Oct 16, 2018
@jacg
Deal with 1 hit in voxelize_hits
9a4170e 
Closes next-exp#328

Previously, the code was crashing when a hit collection contained only
one item.
jmbenlloch pushed a commit to jmbenlloch/IC-1 that referenced this issue Oct 16, 2018
@jacg
Ensure that at least one bin is required
fdb2c06 
Fixes next-exp#328.
jmbenlloch pushed a commit to jmbenlloch/IC-1 that referenced this issue Oct 16, 2018
@jacg
Deal with 1 hit in voxelize_hits
c42102b 
Closes next-exp#328

Previously, the code was crashing when a hit collection contained only
one item.
jmbenlloch pushed a commit that referenced this issue Oct 16, 2018
@jacg
Ensure that at least one bin is required
5dd4ebe 
Fixes #328.
jmbenlloch pushed a commit that referenced this issue Oct 16, 2018
@jacg
Deal with 1 hit in voxelize_hits
01b102a 
Closes #328

Previously, the code was crashing when a hit collection contained only
one item.
jmbenlloch pushed a commit to jmbenlloch/IC-1 that referenced this issue Oct 16, 2018
@jacg
Ensure that at least one bin is required
695dfc9 
Fixes next-exp#328.
jmbenlloch pushed a commit to jmbenlloch/IC-1 that referenced this issue Oct 16, 2018
@jacg
Deal with 1 hit in voxelize_hits
5da91ca 
Closes next-exp#328

Previously, the code was crashing when a hit collection contained only
one item.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacg @paolafer