Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hits_from_df forces event numbers to be int32 #838

Closed
gonzaponte opened this issue Jun 13, 2023 · 0 comments · Fixed by #884
Closed

hits_from_df forces event numbers to be int32 #838

gonzaponte opened this issue Jun 13, 2023 · 0 comments · Fixed by #884
Assignees
Labels
easy good first issue Issues for people willing to get into IC

Comments

@gonzaponte
Copy link
Collaborator

The implementation of this function forces the event number to be a 32-bit signed integer. This creates a problem when processing backgrounds for NEXT100, where event numbers need to be represented as 64-bit integers.
I do not remember the reason for this choice and the comment in the code doesn't explain it fully.
We need to assess whether there is a real need for this restriction or if it's just a ghost from the past.
Initial checks by @martinperezmaneiro indicate that it is no longer necessary.

@gonzaponte gonzaponte added good first issue Issues for people willing to get into IC easy labels Jun 13, 2023
@gonzaponte gonzaponte added this to To do in Processing chain refactor via automation Jun 13, 2023
Processing chain refactor automation moved this from To do to Done Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy good first issue Issues for people willing to get into IC
Development

Successfully merging a pull request may close this issue.

2 participants