[Step1] 지하철 노선 관리 #166
Merged
[Step1] 지하철 노선 관리 #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wheejuni
approved these changes
Jun 4, 2021
Comment on lines
+39
to
+40
| public ResponseEntity<LineResponse> updateLine(@PathVariable Long lineId, | ||
| @RequestBody LineRequest lineRequest |
There was a problem hiding this comment.
첫 번째 파라메터도 한줄을 강제 개행해서 작성해주셨으면 어땠을까 하는 생각은 들어요.
같은 라인에 두 파라메터 모두 위치할 수 있도록요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요. 리뷰어님😃
이번 우테캠Pro 에 참여하게된 김정규입니다.
이번 인수테스트 주도개발 미션 잘 부탁드리겠습니다.
마지막으로, 커밋을 나누어 작업하고자 의도했는데, REST-Assurd 를 체득하는 과정에서 Line 관련 테스트 코드를 한번에 Commit으로 작업되었습니다.
다음 단계에서는 REST-Assurd 를 조금더 체득하여, 의도적으로 기능적 커밋을 나눌수 있도록 하겠습니다.
감사합니다.