[김대겸] Step1 PR

README.md

@@ -1,54 +1,8 @@
-<p align="center">
-    <img width="200px;" src="https://raw.githubusercontent.com/woowacourse/atdd-subway-admin-frontend/master/images/main_logo.png"/>
-</p>
-<p align="center">
-  <img alt="npm" src="https://img.shields.io/badge/npm-6.14.15-blue">
-  <img alt="node" src="https://img.shields.io/badge/node-14.18.2-blue">
-  <a href="https://edu.nextstep.camp/c/R89PYi5H" alt="nextstep atdd">
-    <img alt="Website" src="https://img.shields.io/website?url=https%3A%2F%2Fedu.nextstep.camp%2Fc%2FR89PYi5H">
-  </a>
-  <img alt="GitHub" src="https://img.shields.io/github/license/next-step/atdd-subway-admin">
-</p>
+# 인수 테스트 주도 개발
 
-<br>
+## 🚀 1단계 - 지하철역의 인수 테스트 작성
 
-# 지하철 노선도 미션
-[ATDD 강의](https://edu.nextstep.camp/c/R89PYi5H) 실습을 위한 지하철 노선도 애플리케이션
-
-<br>
-
-## 🚀 Getting Started
-
-### Install
-#### npm 설치
-```
-cd frontend
-npm install
-```
-> `frontend` 디렉토리에서 수행해야 합니다.
-
-### Usage
-#### webpack server 구동
-```
-npm run dev
-```
-#### application 구동
-```
-./gradlew bootRun
-```
-<br>
-
-## ✏️ Code Review Process
-[텍스트와 이미지로 살펴보는 온라인 코드 리뷰 과정](https://github.com/next-step/nextstep-docs/tree/master/codereview)
-
-<br>
-
-## 🐞 Bug Report
-
-버그를 발견한다면, [Issues](https://github.com/next-step/atdd-subway-admin/issues) 에 등록해주세요 :)
-
-<br>
-
-## 📝 License
-
-This project is [MIT](https://github.com/next-step/atdd-subway-admin/blob/master/LICENSE.md) licensed.
+### 기능 요구사항
+-[X] 지하철역 관련 인수 테스트를 완성하세요.
+    -[X] 지하철역 목록 조회 인수 테스트 작성하기
+    -[X] 지하철역 삭제 인수 테스트 작성하기

src/test/java/nextstep/subway/station/StationAcceptanceTest.java

@@ -16,6 +16,8 @@
 import java.util.Map;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.hamcrest.Matchers.hasItems;
+import static org.hamcrest.Matchers.not;
 
 @DisplayName("지하철역 관련 기능")
 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
@@ -38,28 +40,34 @@ public void setUp() {
     @DisplayName("지하철역을 생성한다.")
     @Test
     void createStation() {
+        //@formatter:off
+
         // when
         Map<String, String> params = new HashMap<>();
         params.put("name", "강남역");
 
         ExtractableResponse<Response> response =
-                RestAssured.given().log().all()
-                        .body(params)
-                        .contentType(MediaType.APPLICATION_JSON_VALUE)
-                        .when().post("/stations")
-                        .then().log().all()
-                        .extract();
+                RestAssured.given()
+                                .log().all()
+                                .body(params)
+                                .contentType(MediaType.APPLICATION_JSON_VALUE)
+                            .when().post("/stations")
+                            .then().log().all()
+                            .extract();
 
         // then
         assertThat(response.statusCode()).isEqualTo(HttpStatus.CREATED.value());
 
         // then
         List<String> stationNames =
-                RestAssured.given().log().all()
-                        .when().get("/stations")
-                        .then().log().all()
-                        .extract().jsonPath().getList("name", String.class);
+                RestAssured.given()
+                                .log().all()
+                            .when().get("/stations")
+                            .then().log().all()
+                            .extract().jsonPath().getList("name", String.class);
         assertThat(stationNames).containsAnyOf("강남역");
+
+        //@formatter:on
     }
 
     /**
@@ -70,27 +78,27 @@ void createStation() {
     @DisplayName("기존에 존재하는 지하철역 이름으로 지하철역을 생성한다.")
     @Test
     void createStationWithDuplicateName() {
+        //@formatter:off
+
         // given
         Map<String, String> params = new HashMap<>();
         params.put("name", "강남역");
-
-        RestAssured.given().log().all()
-                .body(params)
-                .contentType(MediaType.APPLICATION_JSON_VALUE)
-                .when().post("/stations")
-                .then().log().all();
+        givenCreateStation(params);
 
         // when
         ExtractableResponse<Response> response =
-                RestAssured.given().log().all()
-                        .body(params)
-                        .contentType(MediaType.APPLICATION_JSON_VALUE)
-                        .when().post("/stations")
-                        .then().log().all()
-                        .extract();
+                RestAssured.given()
+                                .log().all()
+                                .body(params)
+                                .contentType(MediaType.APPLICATION_JSON_VALUE)
+                            .when().post("/stations")
+                            .then().log().all()
+                            .extract();
 
         // then
         assertThat(response.statusCode()).isEqualTo(HttpStatus.BAD_REQUEST.value());
+
+        //@formatter:on
     }
 
     /**
@@ -101,6 +109,26 @@ void createStationWithDuplicateName() {
     @DisplayName("지하철역을 조회한다.")
     @Test
     void getStations() {
+        //@formatter:off
+
+        // given
+        String station1 = "강남역";
+        String station2 = "종각역";
+        givenCreateStation(Map.of("name", station1));
+        givenCreateStation(Map.of("name", station2));
+
+        // when & then
+        RestAssured.given()
+                        .contentType(MediaType.APPLICATION_JSON_VALUE)
+                        .log().all()
+                    .when()
+                        .get("/stations")
+                    .then()
+                        .statusCode(200)
+                        .assertThat().body("name", hasItems(station1, station2))
+                        .log().all();;
+
+        //@formatter:on
     }
 
     /**
@@ -111,5 +139,48 @@ void getStations() {
     @DisplayName("지하철역을 제거한다.")
     @Test
     void deleteStation() {
+        //@formatter:off
+
+        // given
+        String station1 = "강남역";
+        givenCreateStation(Map.of("name", station1));
+
+        // when
+        RestAssured.given()
+                        .log().all()
+                    .when()
+                        .delete("/stations/1")
+                    .then()
+                        .statusCode(204)
+                        .log().all();;
+
+
+        // then
+        RestAssured.given()
+                       .contentType(MediaType.APPLICATION_JSON_VALUE)
+                        .log().all()
+                    .when()
+                        .get("/stations")
+                    .then()
+                        .statusCode(200)
+                        .assertThat().body("name", not(hasItems(station1)))
+                        .log().all();
+
+        //@formatter:on
+    }
+
+    private void givenCreateStation(final Map<String, String> params) {
+        //@formatter:off
+
+        RestAssured.given()
+                        .log().all()
+                        .body(params)
+                        .contentType(MediaType.APPLICATION_JSON_VALUE)
+                    .when()
+                        .post("/stations")
+                    .then()
+                        .log().all();
+
+        //@formatter:on
     }
 }