-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π 1λ¨κ³ - κ²½λ‘ μ‘°ν νμ μΆκ° #112
Conversation
2022. 02. 17. README.md - μ€μ΅ μ¬ν μ 리 Resolves : loop-study See also : junwoochoi
2022. 02. 17. build.gradle - μ½λ μμ index.adoc - μ½λ μμ Resolves : loop-study See also : junwoochoi
2022. 02. 17. PathDocumentation - λ¬Έμν μ€μ΅ PathSteps - λ¬Έμν λμ°λ―Έ ν΄λμ€ Resolves : loop-study See also : junwoochoi
2022. 02. 17. README.md - step1 μꡬμ¬ν μ 리 Resolves : loop-study See also : junwoochoi
2022. 02. 17. PathAcceptanceTest - λ Έμ κ³Ό ꡬκ°μ μΈμλ‘ μμμκ° μΆκ° Resolves : loop-study See also : junwoochoi
2022. 02. 17. LineRequest, SectionRequest - μμμκ° μΆκ° - κ΄λ ¨ ν μ€νΈλ μμ Resolves : loop-study See also : junwoochoi
2022. 02. 17. PathAcceptanceTest - ν μ€νΈ λͺ λͺ μμ PathDocumentation - ν μ€νΈ μ€ν λΉμ μμμκ° μΆκ° PathResponse - μμμκ° μΆκ° Resolves : loop-study See also : junwoochoi
2022. 02. 17. PathAcceptanceTest, PathDocumentation, PathSteps - μκ°κ³Ό 거리λ₯Ό ꡬλΆνλ μΈμ μΆκ° Resolves : loop-study See also : junwoochoi
2022. 02. 17. μΆκ°λ μμμκ°μ κ΄λ ¨λ ν΄λμ€ μμ Resolves : loop-study See also : junwoochoi
2022. 02. 17. PathController - κ²½λ‘ μ‘°ν λ©μλμ μκ°κ³Ό μ ν νμ μ ꡬλΆνλ μΈμ μΆκ° SubwayMap - μ ν νμ ꡬλΆμΌλ‘ λ‘μ§ λ³κ²½ Path - μ΅λ¨ μκ° λ©μλ νΈμΆ μΆκ° κ΄λ ¨λ ν μ€νΈλ€ μμ Resolves : loop-study See also : junwoochoi
2022. 02. 17. SubwayMapTest, PathDocumentation - μ΅λ¨ μκ° ν μ€νΈ μΆκ° Resolves : loop-study See also : junwoochoi
2022. 02. 17. PathAcceptanceTest, PathDocumentation, PathSteps - μ νμ κ΄ν μ€λ³΅ μ½λ κ°μ Resolves : loop-study See also : junwoochoi
2022. 02. 17. PathSteps - κ° νλ μ€λͺ μΆκ° Resolves : loop-study See also : junwoochoi
2022. 02. 17. PathAcceptanceTest - ꡬκ°μ μ’ λ ꡬλΆνκΈ° μν 거리 λ° μκ° μμ Resolves : loop-study See also : junwoochoi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μλ
νμΈμ! μνλ λλ‘ μλμ¨λ€λ λ§μμ΄ νΉμ μλ μ¬μ§ κ°μ λͺ¨μ΅μ μνμ
¨λ κ±ΈκΉμ?
μλ§ asciidoc/index.adocμ μ€λν« μΆκ°λ₯Ό μν΄μ£Όμ
μ κ·Έλ° κ² κ°μ΅λλ€.
https://docs.spring.io/spring-restdocs/docs/current/reference/html5/#getting-started-using-the-snippets
μλ¬Έμλ₯Ό νμΈνμλ©΄ μ‘°κΈ λμμ΄ λμ€ κ² κ°μμ :)
μΆκ°μ μΌλ‘ λͺκ°μ§ μ½λ©νΈ λ¬μ보μλλ° νμΈ λΆνλ립λλ€! π
private List<Line> lines; | ||
private String type; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typeμ enumμ νμ©ν΄μ ννν΄λ³΄μλ©΄ μ΄λ¨κΉμ?
https://velog.io/@nawhew/%EC%9E%90%EB%B0%94-Enum%EC%9D%84-%EB%8D%94-%EC%9E%98%EC%93%B0%EA%B8%B0-%EC%9C%84%ED%95%9C-%EB%B0%A9%EB%B2%95
return ResponseEntity.ok(pathService.findPath(source, target)); | ||
public ResponseEntity<PathResponse> findPath(@RequestParam Long source, | ||
@RequestParam Long target, | ||
@RequestParam String type) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type=BLABLA
μ²λΌ μ΄μν κ°μ΄ λ€μ΄μλ DISTANCE
λ§ μλλ©΄ λ€ DurationκΈ°μ€μΌλ‘ μ‘°νκ° λκ³ μμ κ² κ°λ€μ γ
γ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μ ν¨μ±μ μμ΄λ²λ Έλ€μ...π
λΉ λ₯΄κ² μμ νκ² μ΅λλ€.
src/test/java/nextstep/subway/acceptance/PathAcceptanceTest.java
Outdated
Show resolved
Hide resolved
2022. 02. 17. PathSteps.java - λ¬Έμμλν 컀μ€ν°λ§μ΄μ§ μΆκ° index.adoc, path.adoc - 컀μ€ν°λ§μ΄μ§ λ¬Έμ μΆκ° Resolves : loop-study See also : junwoochoi
2022. 02. 17. μ¬λ¬ κ²μ¦μ΄ μ‘΄μ¬νλ©΄ assertAllλ‘ λ¬Άμ μ²λ¦¬ Resolves : loop-study See also : junwoochoi
2022. 02. 17. String PathTypeμ EnumμΌλ‘ λ³κ²½ - κ΄λ ¨λ λ‘μ§ μμ - κ΄λ ¨λ ν μ€νΈ λ³κ²½ Resolves : loop-study See also : junwoochoi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μλ
νμΈμ! 1λ¨κ³ λ―Έμ
νΌλλ°±λ μ μ μ©ν΄μ£Όμκ³ λ¬Έμνλ μ μ μ©ν΄μ£Όμ
¨μ΅λλ€!
λ€λ§, κΈ°μ‘΄ ꡬκ°μ΄ μμ λ λ μνμ ννμμ μμμκ°μ ν©μ³μ£Όλ κ² μ΄μΈμλ
μ λ
Όνμ --- 7km, 10λΆ ----------- μμ¬μ
μμ μ€κ°μ κ°λ¨μμ΄ μΆκ°λλ 겨μ°, μκ°μ μͺΌκ°μ£Όλ 거리 λΏλ§ μλλΌ μκ°λ μͺΌκ°μ€μΌνλ λ° ν΄λΉ λΆλΆ μ μ©μ΄ λ―Έν‘ν κ² κ°μ΅λλ€ νλ² νμΈ λΆνλ립λλ€ π
μ λ
Όνμ --3km, 4λΆ --- κ°λ¨μ ----4km, 6λΆ ---- μμ¬μ
2022. 02. 17. Sections - μ€κ°κ΅¬μ μΆκ°μ λ€λ₯Έ μμμκ° λλ½ μμ LineTest - μ€κ°κ΅¬μ μΆκ°μ λλ½λ μμμκ° κ²μ¦ μΆκ° Resolves : loop-study See also : junwoochoi
μλ
νμΈμ 리뷰μ΄λ. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
νΌλλ°± μ μ©ν΄μ£Όμ λΆλΆ νμΈνμ΅λλ€!!!
μ€ν
2λ νμ΄ν
μ
λλ€!ππ
μλ νμΈμ! 리뷰μ΄λ
λ§μ§λ§ μ£Όμ°¨λ₯Ό μ§ννκ² λ λ°νμ² μ λλ€. ππ»ββοΈ
μ΄λ² 첫λ¨κ³λ₯Ό μ§ννλ©΄μ λ¬Έμν 컀μ€ν°λ§μ΄μ§μΌλ‘ μμ±νμ§λ§
gradleμ΄ μ λλ‘ μΈμμ΄ μλμ΄μ μνλ λͺ¨μ΅μΌλ‘ μΆλ ₯μ΄ λμ§ μκ³ μμ΅λλ€ π
μ΄λ₯Ό ν΄κ²°ν μ μλ λ°©λ²μ΄ μλ€λ©΄ ν€μλ λΆνλλ¦¬κ² μ΅λλ€.
κ·Έλ¦¬κ³ λΆμ‘±ν μ μ΄ λ§μ νμΈ λΆνλλ¦¬κ² μ΅λλ€.
κ°μ¬ν©λλ€. ππ»ββοΈ