-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
๐ 3๋จ๊ณ - ์๊ธ ์ ์ฑ ์ถ๊ฐ #132
Conversation
2022. 02. 22. Path - ์กฐํ๋ ๊ฒฝ๋ก๋ง ๋ด๋ ๊ฑธ๋ก ๋ณต๊ตฌ PathResponse - ์์ฒญํ ๊ฒฝ๋ก์ ์ต๋จ ๊ฒฝ๋ก ๋ฐ๋ ํํ๋ก ์์ PathService - PathResponse.of() ํธ์ถ ํ์์ ๋ง๊ฒ ๋ก์ง ์ Resolves : loop-study See also : junwoochoi
2022. 02. 22. README.md - ์๊ธ ์ ์ฑ ์๊ตฌ์ฌํญ ์ ๋ฆฌ Resolves : loop-study See also : junwoochoi
2022. 02. 22. LineAcceptanceTest, LineSteps - ๋ ธ์ ์์ฑ ์ธ์์ ๋ ธ์ ์๊ธ ์ถ๊ฐ Resolves : loop-study See also : junwoochoi
2022. 02. 22. Line, LineRequest - ์ถ๊ฐ ์๊ธ ํ๋ ์ถ๊ฐ LineService - ๋ ธ์ ์์ฑ ์, ์ถ๊ฐ ์๊ธ ๋ฃ๋ ๋ก์ง ์ถ๊ฐ LineFixture - ๋ ธ์ ํฝ์ค์ฒ ์์ฑ LineServiceMockTest, LineServiceTest, LineTest, SubwayMapTest - ์ถ๊ฐ๋ ํ๋์ ๊ด๋ จ๋ ํ ์คํธ ์์ Resolves : loop-study See also : junwoochoi
2022. 02. 22. SubwayMapTest - ์งํ์ฒ ์ญ๊ณผ ๋ ธ์ ๊ด๊ณ ํํ Resolves : loop-study See also : junwoochoi
2022. 02. 22. ์๊ธ ํ๋ BigDecimal๋ก ๋ณ๊ฒฝ Resolves : loop-study See also : junwoochoi
2022. 02. 22. AgeFareTest - ๋์ด์ ๋ฐ๋ฅธ ์๊ธํ ์ธ ํ ์คํธ ์ถ๊ฐ Resolves : loop-study See also : junwoochoi
2022. 02. 22. PathFare -> DistanceFare๋ก ๋ณ๊ฒฝ Resolves : loop-study See also : junwoochoi
2022. 02. 22. AgeFare - ๋์ด๋ณ ์๊ธ์ ๋ถ๋ฆฌ Resolves : loop-study See also : junwoochoi
2022. 02. 22. AgeFare - ๋์ด๋ณ ์๊ธ์ก ๊ธฐ๋ฅ ๊ตฌํ AgeFareTest - ๋์ด๋ณ ํ ์ธ๊ธ์ก ํ ์คํธ ์ถ๊ฐ Resolves : loop-study See also : junwoochoi
2022. 02. 22. PathAcceptanceTest - ํ ํฐ ๋ก๊ทธ์ธ ํ ์คํธ ์ถ๊ฐ Resolves : loop-study See also : junwoochoi
2022. 02. 22. AuthenticationPrincipal - ๋น๋ก๊ทธ์ธ ์ฌ๋ถ ํ๋ ์ถ๊ฐ AuthenticationPrincipalArgumentResolver - ๋น๋ก๊ทธ์ธ์ฉ ๋๊ฐ์ฒด ์ฃผ์ ๋ก์ง ์ถ๊ฐ NullLoginMember - ๋น๋ก๊ทธ์ธ์ฉ ๋๊ฐ์ฒด ์์ฑ PathController - LoginMember ์ธ์ ์ถ๊ฐ PathService - ๊ฒฝ๋ก์ฐพ๋ ๋ฉ์๋์ ๋์ด ์ธ์ ์ถ๊ฐ PathDocumentation - ๋ณ๊ฒฝ๋ ๋ก์ง์ ๋ง๊ฒ ์คํ ๋น ์์ Resolves : loop-study See also : junwoochoi
2022. 02. 22. PathFare - ์ ์ฑ ๋ณ ์๊ธ ๊ณ์ฐํ๋ ๊ฐ์ฒด ์์ฑ PathService - ์ด์ ๊ด๋ จ ๋ก์ง ๋ณ๊ฒฝ PathResponse - ์ธ์ Path -> PathFare ๋ณ๊ฒฝ Sections, Section, Path - ์ต๋ ์ถ๊ฐ ์ด์ ๊ตฌํ๋ ๋ก์ง ์ถ๊ฐ Path - ์ด์ ์ ์ด์ ๋น์ฉ ๊ตฌํ๋ ๋ฉ์๋ ์ ๊ฑฐ PathDocumentation - ๋ณ๊ฒฝ๋ ๋ก์ง์ ๋ง๊ฒ ์คํ ๋น ์์ SubwayMapTest - ์ต๋ ์ด์ ๊ตฌํ๋ ํ ์คํธ ์ถ๊ฐ PathAcceptanceTest - ๋์ด๋ณ ์๊ธ์ ๋ฐ ์ถ๊ฐ์ด์ ์ธ์ํ ์คํธ ์ถ๊ฐ Resolves : loop-study See also : junwoochoi
2022. 02. 23. README.md - ์ฒดํฌ๋ฆฌ์คํธ ์์ Resolves : loop-study See also : junwoochoi
2022. 02. 23. LineFixture - Station ์์ฑ ๋ก์ง ์ถ๊ฐ LineServiceMockTest, LineTest, SubwayMapTest - new Station ์ฝ๋ -> createStation ํธ์ถ๋ก ๋ณ๊ฒฝ Resolves : loop-study See also : junwoochoi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์๋
ํ์ธ์! ํ์ฒ ๋!
๋ฏธ์
์ ๋ง ๊น๋ํ ์ ์ํํด์ฃผ์
จ๋ค์ ๐
ํ
์คํธ๋ ๊ผผ๊ผผํ ํด์ฃผ์๊ณ , ๋ก์ง๋ ๋๋ฉ์ธ์ ์์ง๋๊ฒ ์ ๊ตฌํํด์ฃผ์ ๊ฒ ๊ฐ์ต๋๋ค! ๐ฏ
๋ช๊ฐ์ง ๊ฐ๋จํ ์ฝ๋ฉํธ ๋ฌ์๋ณด์๋๋ฐ ํ์ธํด์ฃผ์๋ฉด ๊ฐ์ฌํ๊ฒ ์ต๋๋ค!
- ์ ๋ ์์ฑํ์ ๋ฐฉ๋ฒ ์ข๋ค๊ณ ์๊ฐํฉ๋๋ค. null๋ก ๋ฆฌํดํ ์๋ ์์ง๋ง, ๊ทธ๋ ๊ฒ ๋๋ฉด null์ฒดํฌ๊ฐ ๋งค๋ฒ ํ์ํ๊ธฐ๋ ํ๊ณ ๋ญ๊ฐ ๋ช ํํ์ง ์์ ๊ฒ ๊ฐ์์์ :) ๋ ๊ถ๊ธํ์๋ฉด, Spring Security์์ AnonymousAuthenticationToken์ด๋ผ๋ ํด๋์ค๋ ์ด๋ป๊ฒ ๋์ด์๋์ง ๊ตฌ๊ฒฝํด๋ณด๋ ๊ฒ๋ ์ข์ ๋ฐฉ๋ฒ์ผ๋ก ๋ณด์ ๋๋ค!
- ์ ๋ ๋์ด๋ง ๋ฃ๋ ๊ฒ๋ณด๋ค๋ LoginMember ๊ฐ์ฒด๋ฅผ ๋๊ธฐ๋๊ฒ ๋ ์ข๋ค๊ณ ์๊ฐํฉ๋๋ค. ํ์ฌ๋ ๋์ด๋ง ๊ธฐ์ค์ด์ง๋ง, LoginMember์ ์๋ฅผ ๋ค์ด ์ฑ๋ณ์ด ๋ค์ด๊ฐ๊ฑฐ๋, ์ง์ ์ด ๋ค์ด๊ฐ๊ฑฐ๋, ๊ธฐํ ๋ฑ๋ฑ์ ์ ์ ์ ๋ณด๊ฐ ๋ค์ด๊ฐ๊ฒ ๋๊ณ , ๊ทธ์ ๋ฐ๋ฅธ ํ ์ธ์ ์ฑ ์ด ์ถ๊ฐ์ ์ผ๋ก ๋์ฌ ์ ์์ง ์์๊น......? ํ๋ ์๊ฐ์ ๋๋ค.
- ์ง๊ธ์ฒ๋ผ ๋๋ฉ์ธ๋ณ๋ก ๋ฌถ์ด์ ํฉํ ๋ฆฌ ๋ฉ์๋๋ฅผ ๋ง๋ค์ด์ ์ฌ์ฉํ์๋ ๊ฒ ์ข๋ค๊ณ ์๊ฐํฉ๋๋ค. ๊ฐ ํ ์คํธ ์ผ์ด์ค๋ ์ํฉ์ ๋ฐ๋ผ ํฉํ ๋ฆฌ ๋ฉ์๋์ ๋ค์ด๋ฐ์ผ๋ก ํด๋น ์ผ์ด์ค์ ๋ํ ์๋ฏธ๋ฅผ ๋ฃ์ด์ฃผ๋ฉด ๊ฐ๋ ์ฑ์ด ์ฌ๋ผ๊ฐ๋ฉด์ ๊ด๋ฆฌ๋ ์กฐ๊ธ ๋ ์ฉ์ดํด์ง์ง ์์๊น ์ถ๊ธฐ๋ ํ๋ค์ :)
src/main/java/nextstep/auth/authorization/AuthenticationPrincipalArgumentResolver.java
Outdated
Show resolved
Hide resolved
2022. 02. 25. final ์ ์ธ Resolves : loop-study See also : junwoochoi
2022. 02. 25. PathFare - ์งํ์ฒ ์ด์ ๊ณ์ฐ๋ก์ง ์์ฑ์์ ์ผ๋ก ๋ณ๊ฒฝ Resolves : loop-study See also : junwoochoi
2022. 02. 25. PathController - PathService์ LoginMember ๊ฐ์ฒด๋ก ๋๊น - ๊ด๋ จ๋ ๋ก์ง ๋ณ๊ฒฝ Resolves : loop-study See also : junwoochoi
2022. 02. 25. NullLoginMember - ์ฑ๊ธํค์ผ๋ก ๋ณ๊ฒฝ Resolves : loop-study See also : junwoochoi
์๋
ํ์ธ์ ๋ฆฌ๋ทฐ์ด๋! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์๋ ํ์ธ์! ๋ง์ง๋ง ๋ฏธ์ ๊น์ง ์ด์ฌํ ๋ฌ๋ ค์ค์๋๋ผ ์ ๋ง ๊ณ ์๋ง์ผ์ จ์ต๋๋ค!!
์์ผ๋ก๋ ์ ๋ฌด ๋ฐ ํ์ตํ์๋ฉด์ ATDD ๋ง์ด ํ์ฉํด์ฃผ์๊ธธ ์์ํ๊ฒ ์ต๋๋ค! ๐ฅ
public static NullLoginMember getInstance() { | ||
return instance; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ฑ๊ธํค ๊ฐ์ฒด ๊ตฌํ ๐
https://readystory.tistory.com/116
์ฑ๊ธํค์ ๊ตฌํํ๋ ์ฌ๋ฌ๊ฐ์ง ๋ฐฉ๋ฒ์ด ์์ผ๋ ํ๋ฒ ํจ๊ป ์ฐธ๊ณ ํด๋ณด์๋ฉด ์ข๊ฒ ๋ค์ :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋งํฌ ๊ฐ์ฌํฉ๋๋ค!
์๋ ํ์ธ์ ๋ฆฌ๋ทฐ์ด๋!
๋ฐํ์ฒ ์ ๋๋ค.
์ด๋ฒ ๋จ๊ณ๋ฅผ ์งํํ๋ฉด์ ์ฌ๋ฌ๊ฐ์ง ์ง๋ฌธ์ด ์์ต๋๋ค.
์์ง์ ์์ํ JWT ๋ก๊ทธ์ธ์ NullLoginMember ๊ฐ์ฒด๋ฅผ ์ถ๊ฐํด๋ณด๋ ค๊ณ ์๋ํด๋ดค๋๋ฐ, ํด๋น ๋ฐฉ์์ด ๋ง๋์ง ๊ถ๊ธํฉ๋๋ค.
PathController์ LoginMember ์์กด์ฑ์ด ์ถ๊ฐ๋์ด์, PathController์์ ๋์ด๋ง ๋ฝ์์ ์ด์ ๋น์ฉ์ ์ฌ์ฉํ๊ณ ์์ต๋๋ค.
๋์ด๊ฐ ์๋๋ผ LoginMember ์์กด์ฑ ์์ฒด๋ฅผ ์๋น์ค๊ณ์ธต๊ณผ ๋๋ฉ์ธ๊ณ์ธต๊น์ง ๋๊ธฐ๋ ๋ฐฉ์๊ณผ ๋น๊ตํ๋ฉด ๋ฌด์์ด ๋ ์ข๋ค๊ณ ์๊ฐ ๋์๋์ง ๊ถ๊ธํฉ๋๋ค.
๋จ์ํ ์คํธ์์ LineFixture๋ก Line, Station ์์ฑ์ ๋ชฐ์ ๋ฃ์์ต๋๋ค.
๊ท๋ชจ๊ฐ ์ปค์ง ์๋ก ํฝ์ค์ณ์ ๋ก์ง๋ ๋ง์์ง๊ณ , ์ด๋ฅผ ์ฌ์ฉํ๋ ํ ์คํธ๋ ๋ง์์งํ ๋ฐ ์ถํ ํฝ์ค์ณ๋ฐ์ดํฐ ๋ณต์ก์ฑ์ ์ด๋ค ๋ฐฉ์์ผ๋ก ๊ด๋ฆฌํ๋์ง ๊ถ๊ธํฉ๋๋ค.
ํ์ธ ๋ถํ๋๋ฆฝ๋๋ค. ๐๐ปโโ๏ธ
๊ฐ์ฌํฉ๋๋ค