[김대겸] Step1 PR #756
Merged
[김대겸] Step1 PR #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sections 일급 컬렉션 추가
wooobo
approved these changes
Nov 26, 2022
| - [X] Stations 조회 기능 | ||
| - [X] Domain의 단위 테스트를 작성하기 | ||
| - [X] 새로운 로직 만들기 | ||
| - [X] 정상 동작 확인 후 기존 로직 제거 |
| void addSection() { | ||
| Station 시청역 = new Station("시청역"); | ||
|
|
||
| line.addSection(new Section(종각역, 시청역, 5)); |
|
|
||
| @BeforeEach | ||
| void setUp() { | ||
| 종각역 = new Station("종각역"); |
There was a problem hiding this comment.
테스트 픽스처를 올바르게 사용하도록 습관들여봐야겠습니다. 좋은 정보 공유 감사드립니다!
| .findFirst(); | ||
| } | ||
|
|
||
| private Optional<Section> findUpStation(final Station station) { |
There was a problem hiding this comment.
Optional 사용시 잘 정리된 블로그 내용있어서 공유해요~
There was a problem hiding this comment.
Optional 바르게 쓰는 방법에 대해 잘 정리가 되어있네요 👍
유용한 정보 감사합니다.
| this.distance = new Distance(distance); | ||
| } | ||
|
|
||
| public Section(Station upStation, Station downStation, int distance) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 리뷰어님 😄
Step1 인수 테스트 기반 리팩터링 PR 리뷰 요청 드립니다.
잘 부탁드립니다 :)