[김대겸] Step2 PR #765
Merged
[김대겸] Step2 PR #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooobo
approved these changes
Nov 27, 2022
| public Distance(final int value) { | ||
| this.value = value; | ||
| protected Distance() { | ||
| this(0); |
There was a problem hiding this comment.
매직넘버 상수화 해보면 좋을것 같아요!
private final int ZERO 이런식으로요!
| Optional<Section> originalSection = sections.findSameDownStation(section); | ||
| originalSection.ifPresent(it -> it.updateDownStation(section)); | ||
| Section originalSection = sections.findSameDownStation(section); | ||
| if (Objects.nonNull(originalSection)) { |
There was a problem hiding this comment.
- indent(들여쓰기) depth를 2단계에서 1단계로 줄여라.
- depth의 경우 if문을 사용하는 경우 1단계의 depth가 증가한다. if문 안에 while문을 사용한다면 depth가 2단계가 된다.
프로그래밍 요구사항에 맞지 않네요 ㅜ
There was a problem hiding this comment.
indent 가 2단계로 되어 있었군요 😢 😢 수정하도록 하겠습니다.
|
|
||
| assertThatThrownBy(() -> pathFinder.getShortestPath(강남역, 강남역)) | ||
| .isInstanceOf(IllegalArgumentException.class) | ||
| .hasMessageContaining("출발역과 도착역이 " + 강남역.getName() + "으로 동일합니다."); |
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| public class LineSectionAcceptanceStep { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 리뷰어님,
2단계 - 경로 조회 기능 PR 입니다.
이번 리뷰도 잘 부탁드립니다 🙏 🙏 🙏