[김대겸] Step3 PR #803
Merged
[김대겸] Step3 PR #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooobo
approved these changes
Dec 1, 2022
|
|
||
| @Transactional | ||
| public void deleteFavoriteById(final Long id, final Long memberId) { | ||
| Favorite favorite = favoriteRepository.findByIdAndMemberId(id, memberId) |
| if (Objects.nonNull(originalSection)) { | ||
| originalSection.updateUpStation(section); | ||
| } | ||
| updateUpStation(section, originalSection); |
|
|
||
| assertAll( | ||
| () -> assertThat(favorites).hasSize(1), | ||
| () -> assertStationId(favorites.get(0).getSourceStation(), favorite.getSourceStation()), |
There was a problem hiding this comment.
해당 테스트에 대해서는 큰문제가 없을것 같지만,
개인적인 관점을 공유해드리면
assertThat(..).containsExactly 같은 검증을 사용해볼것 같아요!
| @Column(name = "distance") | ||
| private int value; | ||
|
|
||
| protected Distance() { | ||
| this(0); | ||
| this(ZERO); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 리뷰어님,
3단계 - 인증을 통한 기능 구현 PR 입니다.
이번 리뷰도 잘 부탁드립니다 :)