Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1단계] 웹 성능 테스트 #262

Merged
merged 2 commits into from May 2, 2022

Conversation

loop-study
Copy link

안녕하세요!
박현철입니다.
1단계 진행하여 제출합니다.
확인 부탁드립니다.
감사합니다!

2022. 05. 01.
1. README.md
- 1단계 요구사항 및 결과 정리

2. LineRepository.java
- 에러 발생하는 SLEEP 구문 제거

Resolves : loop-study
See also : brainbackdoor
2022. 05. 01.
1. README.md
- 목표 성능 수정

Resolves : loop-study
See also : brainbackdoor
Copy link
Contributor

@brainbackdoor brainbackdoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피드백이 늦었네요~ 1단계 미션 잘 진행하셨어요~
이번 단계는 여기서 머지할게요~

- 렌더링 차단 리소스를 제거합니다.
- /css?family=Roboto:100,300,400,500,700,900
- 이미지 요소에 크기를 명시합니다.
- 현재 logo_small 이미지를 크기를 명시하지 않아 레이아웃이 자동으로 조절하고 있는데 width & height를 명시하여 레이아웃 변경을 개선합니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@brainbackdoor brainbackdoor merged commit 6a03bc3 into next-step:loop-study May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants