[김대겸] Step3 PR #601
Merged
[김대겸] Step3 PR #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geunhwanlee
approved these changes
Dec 11, 2022
Comment on lines
+11
to
+16
| <rollingPolicy class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy"> | ||
| <fileNamePattern>${home}json-%d{yyyyMMdd}-%i.log</fileNamePattern> | ||
| <timeBasedFileNamingAndTriggeringPolicy class="ch.qos.logback.core.rolling.SizeAndTimeBasedFNATP"> | ||
| <maxFileSize>15MB</maxFileSize> | ||
| </timeBasedFileNamingAndTriggeringPolicy> | ||
| </rollingPolicy> |
There was a problem hiding this comment.
날짜가 넘어가거나 사이즈가 15MB를 넘어가면 새로운 파일로 넘어가게 설정하셨네요 👍🏻
하지만 오랫동안 서버를 유지하게된다면 로그파일이 무한정 만들어지게 될텐데요
그럴경우 어떻게 처리를 하는게 좋을지 고민해보면 좋겠네요 😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 리뷰어님~
3단계 - 로깅, 모니터링 리뷰 요청 드립니다.
이번에도 리뷰 잘 부탁드립니다 🙏 🙏 🙏