Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step2 볼링 점수판 PR #157

Merged
merged 87 commits into from Jun 16, 2020
Merged

Step2 볼링 점수판 PR #157

merged 87 commits into from Jun 16, 2020

Conversation

JunilHwang
Copy link

안녕하세요! 볼링 점수판 완료하였습니다.
객체를 어떤식으로 나눠야 좋을지 일주일 내내 고민했네요.. ㅠㅠ
마지막 미션이라 그런지 쉽지 않은 것 같습니다!

리뷰 잘 부탁드립니다~

@JunilHwang
doc: [step2] README.md 추가
0e13e51
@JunilHwang
feat: [step2] PlayerName과 PlayerNameEmptyException 추가
eb07719
@JunilHwang
feat: [step2] InputView 추가
f0da411
@JunilHwang
feat: [step2] PlayerName의 최대 길이 검증 코드 추가
aa63fa4
@JunilHwang
doc: [step2] README.md 약간 수정
00e0842
@JunilHwang
feat: [step2] Score, ScoreRangeException 추가
b280b73
@JunilHwang
feat: [step2] Frame, Frames, FrameScore 등 추가 완료
40e2b50
@JunilHwang
refactor: [step2] PlayerName -> Player 변경
471d041
@JunilHwang
doc: [step2] README.md 수정
5fadb12
@JunilHwang
feat: [step2] Score에 sum method 추가
b22e975
@JunilHwang
refactor: [step2] ofStrike 개선
dfeb4c7
@JunilHwang
feat: [step2] Score에 getValue 추가
715063c
@JunilHwang
feat: [step2] FrameScore에 addScore, totalScore 추가
12091dd
@JunilHwang
feat: [step2] Frames에 init 제거
b65f953
@JunilHwang
feat: [step2] Frame과 Frames에 next method 추가
baf63b9
@JunilHwang
feat: [step2] InputView에 inputScore 추가
643159b
@JunilHwang
refactor: [step2] Player -> PlayerName로 변경
77c27f9
@JunilHwang
feat: [step2] Players 추가
b4d0f0b
@JunilHwang
feat: [step2] PlayerScore 추가
5527843
@JunilHwang
refactor: [step2] Frame의 FrameScore -> PlayerScore로 변경
3f28fef
@JunilHwang
refactor: [step2] Frames에서 player 제거
9c210e1
@JunilHwang
refactor: [step2] refacoring 코드 추가
a2ab4f2
@JunilHwang
feat: [step2] initBy 추가
1e0e77f
@JunilHwang
feat: [step2] init 추가
0740f8c
@JunilHwang
feat: [step2] Frame에 scoreOfPlayer method 추가
f4180bc
@JunilHwang
feat: [step2] Frames에 scoresOfPlayerStream method 추가
bca87bf
@JunilHwang
refactor: [step2] FrameScore - isSpared 리팩토링
a90997a
@JunilHwang
refactor: [step2] Score - sum에서 sumIsStrike로 변경
5a816c7
@JunilHwang
feat: [step2] Controller 작업 중
d366d65
@JunilHwang
feat: [step2] ResultView 오류 수정
ecdf671
@JunilHwang
fix: [step2] sout 제거
b4705d4
@JunilHwang
Merge remote-tracking branch 'origin/step1' into step2
013964a
@JunilHwang
test: [step2] ScoreTest - 값 검증 완료
a80a4c2
@JunilHwang
test: [step2] ScoreTest - 재사용 테스트 및 스트라이크 확인 테스트 완료
abe28b0
@JunilHwang
test: [step2] ScoreTest - 스코어 합 테스트 완료
f21292b
@JunilHwang
test: [step2] ScoresTest - 스트라이크 확인 테스트 완료
27e71ba
@JunilHwang
test: [step2] ScoresTest - 스코어 채워짐 테스트 완료
7e9d305
@JunilHwang
test: [step2] ScoresTest - 스페어 테스트 완료
7bcb6a9
@JunilHwang
test: [step2] ScoresTest - 스코어 합계 테스트 완료
47a737b
@JunilHwang
test: [step2] FinalScoresTest 완료
33c0ac1
@JunilHwang
test: [step2] PlayerTest - 이름 검증 완료
512be2d
@JunilHwang
test: [step2] PlayerTest - 객체 재사용 테스트 완료
ea0cf35
@JunilHwang
test: [step2] NormalFrameTest - 다음 프레임 생성 테스트 완료
bdd595d
@JunilHwang
test: [step2] FinalFrameTest - 다음 프레임 생성 테스트 완료
b7eff87
@JunilHwang
test: [step2] FinalFrameTest - 다음 프레임 생성 테스트 수정
e137203
@JunilHwang
test: [step2] FramesTest 완료
f68eafa
ssosso
ssosso requested changes Jun 14, 2020
View reviewed changes
Copy link

@ssosso ssosso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트도 꼼꼼하고 구조에도 고민을 많이 한 흔적이 보이네요 💯
몇 가지 개선하면 더 좋아보여 코멘트 남겼습니다.
확인 부탁드립니다~!

src/main/java/bowling/step2/domain/Frames.java Outdated Show resolved Hide resolved
src/main/java/bowling/step2/domain/scores/FinalScores.java Outdated Show resolved Hide resolved
src/main/java/bowling/step2/domain/scores/NormalScores.java Outdated Show resolved Hide resolved
src/main/java/bowling/step2/domain/scores/Scores.java Outdated Show resolved Hide resolved
src/main/java/bowling/step2/domain/Player.java Outdated Show resolved Hide resolved
src/main/java/bowling/step2/domain/Player.java Outdated Show resolved Hide resolved
src/main/java/bowling/step2/controller/BowlingController.java Outdated Show resolved Hide resolved
ssosso
ssosso requested changes Jun 16, 2020
View reviewed changes
Copy link

@ssosso ssosso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 반영하니 훨신 깔끔한것 같습니다 👍
조금만 더 개선하면 좋을 것 같아 추가 코멘트 남겼습니다.
확인 부탁드립니다~!

src/main/java/bowling/step2/domain/Frames.java Show resolved Hide resolved
src/main/java/bowling/step2/domain/Player.java Outdated Show resolved Hide resolved
src/main/java/bowling/step2/domain/scores/Scores.java Outdated Show resolved Hide resolved
ssosso
ssosso approved these changes Jun 16, 2020
View reviewed changes
Copy link

@ssosso ssosso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 리뷰 반영 감사합니다! 💯
다음 단계 진행 부탁드려요~!

@ssosso ssosso merged commit 092a050 into next-step:junilhwang Jun 16, 2020
@JunilHwang JunilHwang deleted the step2 branch June 18, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssosso ssosso ssosso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JunilHwang @ssosso