Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step4 - 로또(2등) #543

Merged
merged 4 commits into from May 19, 2022
Merged

Step4 - 로또(2등) #543

merged 4 commits into from May 19, 2022

Conversation

stevejkang
Copy link

안녕하세요! Step4 - 로또(2등) PR 리뷰 요청드립니다.

이전 단계인 Step3에서 머지되면서 해주신 피드백들도 반영해두었습니다.
이제 점점 끝이 보이네요...! 그럼 이번 리뷰도 잘 부탁드리겠습니다 :)

Copy link
Member

@dhmin5693 dhmin5693 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 준영님!

저번에 많이 고생하신 덕분에 상대적으로 많이 바뀌었다는 느낌은 잘 안들게 되네요 😄
소소한 코멘트 남겼으니 확인 후 재요청 부탁드립니다. 🙇‍♂️
거의 다 왔네요. 마지막까지 화이팅입니다! 💪

src/main/java/lotto/domain/LottoTickets.java Outdated Show resolved Hide resolved
src/main/java/lotto/domain/LottoNumbers.java Outdated Show resolved Hide resolved
src/main/java/lotto/domain/LottoNumbers.java Show resolved Hide resolved
src/main/java/lotto/domain/LottoGame.java Outdated Show resolved Hide resolved
src/main/java/lotto/domain/LottoTickets.java Outdated Show resolved Hide resolved
src/main/java/lotto/domain/LottoPrize.java Show resolved Hide resolved
- add first class collection for lotto prize
- add missing tests
Copy link
Member

@dhmin5693 dhmin5693 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피드백 반영 잘해주셨네요!
수고하셨습니다.
마지막 한발자국 남은 만큼 조금만 더 힘내주세요.

다음 미션 진행해주시고 LottoNumbersGenerator 에 unused import는 제거해주세요 :)

@dhmin5693 dhmin5693 merged commit 618a2fa into next-step:stevejkang May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants