Step4 - 로또 (수동) #1828
Merged
Step4 - 로또 (수동) #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#tag @neojjc2 |
neojjc2
approved these changes
Aug 2, 2021
|
|
||
| private int count = 0; | ||
|
|
||
| public static void duplicateValidate(Set<Integer> lottos) { | ||
| if(lottos.size() != MAX_LENGTH) { |
There was a problem hiding this comment.
Set을 이용한 중복제거 좋은데요 👍
컨벤션만 다시 한번 확인하고 가시면 될 것 같습니다 😄
Suggested change
| if(lottos.size() != MAX_LENGTH) { | |
| if (lottos.size() != MAX_LENGTH) { |
|
|
||
| if(duplicated.size() != MAX_LENGTH) { | ||
| throw new IllegalArgumentException("당첨 번호는 중복이 될 수 없습니다."); | ||
| public List<Lotto> manualLottoNumber(int manualCount) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
벌써 마지막 스텝이네요❗️
이번 리뷰도 잘 부탁드립니다😄