Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step2 리팩토링 완료 #527

Merged
merged 76 commits into from May 25, 2020
Merged

Step2 리팩토링 완료 #527

merged 76 commits into from May 25, 2020

Conversation

JunilHwang
Copy link

다시 리뷰 요청 부탁드립니다!

# Conflicts:
#	src/main/java/step2/controller/LottoController.java
#	src/main/java/step2/domain/Lotto.java
#	src/main/java/step2/domain/LottoGame.java
#	src/main/java/step2/domain/LottoShop.java
#	src/main/java/step2/view/ResultView.java
#	src/test/java/step2/domain/LottoGameTest.java
#	src/test/java/step2/domain/LottoShopTest.java
#	src/test/java/step2/domain/LottoTest.java
Copy link

@seok-2-o seok-2-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피드백 반영 잘 해주셨어요 💯
몇가지 추가 코멘트 남겨두었으니 다음 미션에서 반영해주세요.
이어서 다음 미션 진행해주세요.

src/main/java/step2/domain/Lotto.java Show resolved Hide resolved
src/main/java/step2/domain/Lotto.java Show resolved Hide resolved
src/main/java/step2/domain/Lottos.java Show resolved Hide resolved
src/main/java/step2/domain/Lottos.java Show resolved Hide resolved
@seok-2-o seok-2-o merged commit 1defeb2 into next-step:junilhwang May 25, 2020
JunilHwang added a commit to JunilHwang/java-lotto that referenced this pull request May 25, 2020
@JunilHwang JunilHwang deleted the step2 branch June 4, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants