Step2 구현 완료 #133
Merged
Step2 구현 완료 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javajigi
approved these changes
Apr 4, 2019
| @@ -38,6 +38,15 @@ public Question(String title, String contents) { | |||
| this.contents = contents; | |||
| } | |||
|
|
|||
| public void update(Question updatedQuestion) { | |||
There was a problem hiding this comment.
자신이 쓴 글인지에 대한 체크를 이 메소드에서 진행하면 어떨까?
이에 따른 단위 테스트도 구현할 수 있지 않을까?
| this.contents = updatedQuestion.contents; | ||
| } | ||
|
|
||
| public void delete() { |
There was a problem hiding this comment.
자신이 쓴 글인지에 대한 체크를 이 메소드에서 진행하면 어떨까?
이에 따른 단위 테스트도 구현할 수 있지 않을까?
| } | ||
|
|
||
| origin.update(updatedQuestion); | ||
| return questionRepository.save(origin); |
There was a problem hiding this comment.
questionRepository.save(..)와 같이 명시적으로 구현하지 않고 단순히 question.update(updatedQuestion) 만으로도 수정이 가능한지 테스트해 본다.
| } | ||
|
|
||
| origin.delete(); | ||
| questionRepository.save(origin); |
There was a problem hiding this comment.
questionRepository.save(..)와 같이 명시적으로 구현하지 않고 단순히 origin.delete() 만으로도 수정이 가능한지 테스트해 본다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요.
qna 2단계 구현 완료하여 피드백 요청드립니다!