-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step3 구현 완료 #149
Step3 구현 완료 #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acceptance Test, 도메인 테스트 구현 잘 했네요. 💯
단, Acceptance Test를 구현할 때 given/when/then에 대해 다시 한번 생각해 보면 좋을 것 같아요.
첫 번째 피드백에서 question.matchId 대신, equals메소드를 사용했습니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
피드백 빠르게 반영 잘 했네요. 💯
이전에 비해 조금 더 깔끔해진 것 같아요.
Q&A 마지막 단계네요.
내일까지 4단계 마무리하고 과정 마무리하면 좋을 것 같네요.
안녕하세요!
step2에서 주신 피드백 반영, step3 구현에 대한 피드백 요청드립니다.