[step4] 자동차 경주(우승자) 리뷰 부탁드립니다 #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat : 4단계 - 자동차 경주(우승자) 2021. 03. 15 자동차 경주(우승자)를 제출합니다. 1) 패키지로 UI, 도메인 분류 2) 자동차 참가회수 -> 자동차 이름으로 변경 3) 우승자 구분에 따른 기능 추가 4) 상수들을 상수 클래스로 관리 5) 기타 피드백 반영 Resolves : loop-study See also : changgunyee
2021. 03. 15 자동차 이름으로 ",,,,," 입력 시 자동차 Size 없이 진행되어 유효성 추가합니다. Resolves : loop-study See also : changgunyee
2020. 03. 15 기존 3단계에서 추가된 4단계 구현 요소 추가함 Resolves : loop-study See also : changgunyee
changgunyee
approved these changes
Mar 15, 2021
| private int roundCount; | ||
|
|
||
| public GrandPrix(List<String> names, int roundCount) { | ||
| isRoundCountVaild(roundCount); |
There was a problem hiding this comment.
조금 욕심을 내자면 라운드 수를 관리하는 객체를 도입해보는 건 어떨까요?
그리고 isGameEnd, isRoundCountValid와 같은 함수를 해당 클래스에 넣는 것이지요. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 박현철입니다.
이전 피드백과 자동차 경주(우승자)에 추가된 요구사항 반영하여 진행했습니다.✅
새로운 전략패턴을 할당하여 진행할 수 있게 수정했습니다.
부족한 점 있으면 피드백 부탁드리겠습니다!📖📖📖📖📖