[5단계] 자동차 리팩토링 리뷰 부탁듣립니다 #2083
Merged
[5단계] 자동차 리팩토링 리뷰 부탁듣립니다 #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2021. 03. 15 리팩토링 제출합니다. 1) 피드백 반영 2) 그외 int distance, String name 객체 3) 객체화에 따른 테스트 추가 4) 리드미 내용 추가 Resolves : loop-study See also : changgunyee
changgunyee
approved these changes
Mar 16, 2021
| beforeRound.isGameEnd(); | ||
|
|
||
| //then | ||
| assertThat(beforeRound).isEqualTo(afterRound); |
| import java.util.List; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| public class RoundRecord { |
| } | ||
|
|
||
| @ParameterizedTest | ||
| @ValueSource(strings = {"povi123", "1231234", "12312345"}) |
|
|
||
| import java.util.Objects; | ||
|
|
||
| public class Distance { |
|
|
||
| import new_racingcar.constant.MsgConstants; | ||
|
|
||
| public class Name { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 박현철입니다.
마지막 리팩토링 리뷰 부탁드립니다.
기존 Round 를 RoundRecords 로 클래스명 변경했고,
새로운 Round 를 추가하여 Round 관련된 진행상황을 관리하게 변경헀습니다.
그 외에 distance, name 객체화 시켰습니다.
확인 부탁드립니다
감사합니다!