3단계 - 자동차 경주(우승자) #320
Merged
3단계 - 자동차 경주(우승자) #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implements calculator
This reverts commit c017e34.
young891221
approved these changes
Jun 18, 2019
| @@ -3,9 +3,11 @@ | |||
| import racing.strategy.DrivingStrategy; | |||
|
|
|||
| public class Car { | |||
| public int position; | |||
| private String name; | |||
| private int position; | |||
There was a problem hiding this comment.
Car 객체를 일급 객체로 만들기 위해서는 필드값을 하나만 들고 있도록 해야 합니다.
앞으로 모든 객체는 필드값 1개만 가지도록 지향해 보세요!
힌트는 https://jojoldu.tistory.com/412 여기를!
| @@ -7,8 +7,8 @@ | |||
| private List<Car> cars; | |||
| private int moves; | |||
| @@ -28,11 +30,11 @@ private void move() { | |||
| Printer.printResult(cars); | |||
| } | |||
|
|
|||
| private void setCars(int numOfCars) { | |||
| cars = new ArrayList<>(numOfCars); | |||
| private void setCars(List<String> carNames) { | |||
There was a problem hiding this comment.
setter는 이번 과정에서 지양해야될 습관중 하나입니다.
setter 사용하지 않고 로직을 처리하도록 변경 부탁드립니다.
| import java.util.List; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| public class WinnerMaker { |
| @@ -18,6 +18,8 @@ public void startRacing() { | |||
| for (int i = 0; i < this.moves; i++) { | |||
| move(); | |||
| } | |||
|
|
|||
| Printer.printEndGame(new WinnerMaker(cars).getWinners()); | |||
| } | |||
|
|
|||
| private void move() { | |||
There was a problem hiding this comment.
잘 짜신 코드에 비해 단위 테스트가 많이 부족합니다.
저는 그 원인중 하나가 void형 반환에 있다고 생각이 드는데요.
작은 단위 테스트를 만들어 최대한 하나의 메서드는 어떠한 결과값을 반환하도록 코딩을 해보세요.
훨씬 단위 테스트하기 쉬워질 것입니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3단계 - 자동차 경주(우승자) 입니다.
감사합니다!