refactor: 5단계 자동차 경주 (리팩토링) PR 코멘트 반영 #3898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: Step1 PR 코멘트 반영
- 패키지 이동 - RacingCarService.java 삭제 - RacingCars.java 클래스에 레이스 승자 로직 추가 - RacingCarWithWinner.java 역할 분리
Closed
younlll
approved these changes
Oct 10, 2022
| } | ||
|
|
||
| @Override | ||
| public void raceResult(RacingCars racingCars, int numOfRaces) { | ||
| for (int count = 1; count <= numOfRaces; count++) { | ||
| racingCars.move(new RandomMovingStrategy()); | ||
| outputCarsLocation(racingCars); | ||
| outputCarsLocation(racingCars.move(new RandomMovingStrategy())); |
There was a problem hiding this comment.
피드백 드린 내용은 클래스 분리를 의도한 내용이였지만
추후 미션에서는 클래스에 한 가지 역할을 하도록 하셔도 좋을 것 같습니다.
그래도 메소드 분리와 네이밍을 잘 해주셔서 어떤 의도로 구현하셨는지
가독성 측면에서도 좋고 제가 소스코드를 이해하기도 좋았습니다.
There was a problem hiding this comment.
아 넵넵! 코멘트 감사합니다.
다음 미션에서는 말씀하신 클래스 분리로 가져가도록 하겠습니다.
그동안 수고 많으셨습니다 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3852 에 남겨주신 PR 코멘트 반영하였습니다.