1단계 - 학습 테스트 실습 #4116
Merged
1단계 - 학습 테스트 실습 #4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1단계 - 학습 테스트 실습
javajigi
approved these changes
Apr 4, 2023
| @Test | ||
| @DisplayName("size()를 통해 Set의 크기를 확인할 수 있다.") | ||
| void size() { | ||
| assertEquals(3, numbers.size()); |
There was a problem hiding this comment.
Suggested change
| assertEquals(3, numbers.size()); | |
| assertThat(numbers).hasSize(3); |
| @ValueSource(ints = {1, 2, 3}) | ||
| @DisplayName("contains()를 통해 Set에 값이 존재하는지 확인할 수 있다.") | ||
| void contains_01(int value) { | ||
| assertTrue(numbers.contains(value)); |
There was a problem hiding this comment.
Suggested change
| assertTrue(numbers.contains(value)); | |
| assertThat(numbers).contains(1, 2, 3); |
Comment on lines
+14
to
+18
| //given | ||
| String word = "1,2"; | ||
|
|
||
| //when | ||
| String[] result = word.split(","); |
There was a problem hiding this comment.
Suggested change
| //given | |
| String word = "1,2"; | |
| //when | |
| String[] result = word.split(","); | |
| final String[] actual = "1,2".split(","); |
로컬 변수 없이 구현해도 되지 않을까?
Comment on lines
+27
to
+35
| //given | ||
| String word = "1"; | ||
|
|
||
| //when | ||
| String[] result = word.split(","); | ||
|
|
||
| //then | ||
| assertThat(result).containsExactly("1"); | ||
| assertEquals(1, result.length); |
There was a problem hiding this comment.
굳이 given/when/then을 써야 할까?
오히려 가독성을 떨어트리는 것은 아닐까?
빈 공백 라인을 통해 구분하는 것도 좋은 방법이지 않을까?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 멘토님!@ 잘부탁드립니다😀