Step4 리뷰 요청드립니다. #5528
Open
Step4 리뷰 요청드립니다. #5528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 책임 할당 수정 및 객체지향 원칙 반영
- 책임 할당 수정 및 객체지향 원칙 반영
mskangg
requested changes
Mar 27, 2024
Comment on lines
+3
to
+4
| - [X] 자동차 이름은 5자를 초과할 수 없다. | ||
| - [X] 우승자는 한명 이상일 수 있다. |
| gameCount = getGameCount(); | ||
| System.out.println("실행 결과"); | ||
| for (int i = 0; i < gameCount; i++) { | ||
| job(); | ||
| } | ||
|
|
||
| Winner winner = new Winner(); | ||
| System.out.println(FormattingUtil.formattingResult(winner.getWinners(cars)) + "가 최종 우승했습니다."); |
src/main/java/FormattingUtil.java
Outdated
Comment on lines
13
to
18
| for (int i = 0; i < size; i++) { | ||
| sb.append(list.get(i)); | ||
| if (i < size - 1) { | ||
| sb.append(","); | ||
| } | ||
| } |
There was a problem hiding this comment.
규칙 1: 한 메서드에 오직 한 단계의 들여쓰기(indent)만 한다.
indent가 2이상인 메소드의 경우 메소드를 분리하면 indent를 줄일 수 있다.
else를 사용하지 않아 indent를 줄일 수 있다.
인덴트가 2이상이군요 🤔
added 2 commits
March 28, 2024 00:10
|
실행 결과 수정 하였습니다. 추가로 리뷰주신 내용도 반영했습니다. 인덴트를 2로 유지하면서 메서드를 쪼개는게 아직 어색하네요~ |
mskangg
requested changes
Mar 28, 2024
Comment on lines
+20
to
+26
| public List<String> getWinners(Car[] cars) { | ||
| this.filterMaxLength(cars); | ||
| for (Car car : cars) { | ||
| this.checkWinnerCondition(car); | ||
| } | ||
| return this.winners; | ||
| } |
|
|
||
| private void filterMaxLength (Car[] cars) { | ||
| for (Car car : cars) { | ||
| int carStatusLength = car.getStatus().length(); |
There was a problem hiding this comment.
자동차의 길이를 꺼내어 처리하고 있네요!
디미터 법칙에 어긋나고 있습니다
메세지를 보내어 처리해보는건 어떨까요? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
step 3의 최신 코드를 pull받으면서 commit이 같이 딸려왔습니다.
리뷰 요청드립니다.