Step2: 문자열 계산기 PR #761
Merged
Step2: 문자열 계산기 PR #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serverwizard
requested changes
May 13, 2020
serverwizard
approved these changes
May 14, 2020
| return this.result; | ||
| } | ||
|
|
||
| public void calculate () { |
There was a problem hiding this comment.
calculate메소드를 static으로 바꾸고, 생성자에 있는 유효성 검사 로직을 calculate 메소드로 옮긴다면
생성자가 필요 없을 것 같아요~ 이렇게 함으로써 인스턴스 변수(expression)도 제거할 수 있을거구요.
또한 calculate 메소드가 최종 연산 결과까지 리턴을 해준다면 남은 인스턴스 변수(result)도 제거할 수 있겠네요~
There was a problem hiding this comment.
흠 그럼 calulate 메소드에 너무 많은 기능이 들어가는건 아닐까요?
| @ValueSource(strings = { "", "null", " " }) | ||
| void NULL_혹은_공백_테스트 (String expression) { | ||
| assertThatIllegalArgumentException() | ||
| .isThrownBy(() -> calculator.scanExpression(expression.equals("null") ? null : expression)); |
There was a problem hiding this comment.
삼항 연산자를 사용하지 않고, 입력 값이 null인 경우와 공백인 경우의 테스트를 나누는 건 어떨까요?
또한 아래 링크를 통해 @NullAndEmptySource 애노테이션을 학습해보는 것도 좋을 것 같아요.
https://www.baeldung.com/parameterized-tests-junit-5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
문자열 계산기 PR 리뷰 부탁드립니다!