Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Step4] 4단계 - 로또(수동) PR 요청드립니다. #552

Open
wants to merge 21 commits into
base: dajeong
Choose a base branch
from
Open

[Step4] 4단계 - 로또(수동) PR 요청드립니다. #552

wants to merge 21 commits into from

Commits on Dec 6, 2022

  1. [step4] 3단계 리뷰 반영 - 생성자 기본값 

    - LottoRank의 기본값 설정
    dajeong committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    9edc1be View commit details
    Browse the repository at this point in the history

  2. [step4] 3단계 리뷰 반영 - companion object 함수 변경 

    - companion object 함수에서 일반함수로
    dajeong committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    f528f8b View commit details
    Browse the repository at this point in the history

  3. [step4] 3단계 리뷰 반영 - 비효율적인 코드 수정 

    - 함수 실행할때마다 생성되는 객체를 생성자로
    dajeong committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    401a85d View commit details
    Browse the repository at this point in the history

  4. [step4] 3단계 리뷰 반영 - 불필요한 변수 삭제

    dajeong committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    e093e7d View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. [step4] 4단계 기능목록 TODO 정리

    dajeong committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    f9d9dca View commit details
    Browse the repository at this point in the history

  2. [step4] 지불 금액 클래스 생성 

    - 지불 금액에 대한 검증 코드 추가
    dajeong committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    d9d7cae View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. [step4] 4단계 과제 내용 readme에 작성

    dajeong committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    56aba68 View commit details
    Browse the repository at this point in the history

  2. [step4] 로또 번호 클래스 생성, Int 타입을 포장할 Number 클래스 생성

    dajeong committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    77605aa View commit details
    Browse the repository at this point in the history

  3. [step4] 입력 문자열 포장 클래스 생성

    dajeong committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    89e133d View commit details
    Browse the repository at this point in the history

  4. [step4] 패키지 위치 수정

    dajeong committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    3291402 View commit details
    Browse the repository at this point in the history

  5. [step4] 클래스명 변경 Number -> IntegerNumber 

    integer 타입만 다루고 있어 이름 변경
    dajeong committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    6a205a9 View commit details
    Browse the repository at this point in the history

  6. [step4] 실수값 포장 클래스 DoubleNumber 생성

    dajeong committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    0db5155 View commit details
    Browse the repository at this point in the history

  7. [step4] 테스트 추가, 코드 정리

    dajeong committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    76bd302 View commit details
    Browse the repository at this point in the history

  8. [step4] 결과 출력 오류 수정, 테스트 보완

    dajeong committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    17716c8 View commit details
    Browse the repository at this point in the history

  9. [step4] Lotto와 LottoWinner 클래스를 합침, 불필요 코드 삭제, 예외 케이스 처리

    dajeong committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    51f1799 View commit details
    Browse the repository at this point in the history

  10. [step4] 수동 로또 개수, 번호 입력 기능

    dajeong committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    0f56910 View commit details
    Browse the repository at this point in the history

  11. [step4] 수동 로또 생성 기능

    dajeong committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    431d97a View commit details
    Browse the repository at this point in the history

  12. [step4] 생성된 로또 출력 수정

    dajeong committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    8a3e35b View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2022

  1. [step4] 피드백 반영 - 모든 원시값 포장이 아닌 의미있는 값만 포장 

    모든 원시값 포장을 잘못이해하여 생서한 클래스들 제거
    dajeong committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    533f5fb View commit details
    Browse the repository at this point in the history

  2. [step4] 피드백 반영 - 당첨금을 위한 Money 클래스 생성 

    + 수익률 오류 수정
+ Payment 클래스의 프로퍼티명 수정
    dajeong committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    c0e7831 View commit details
    Browse the repository at this point in the history

  3. [step4] 피드백 반영 - 로또 구매 로직 변경 

    payment(지불금액)이 로또를 구매할 때 변경돼야하기 때문에 lottoShop에서 payment를 가지는 구조로 변경
    dajeong committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    01d85e4 View commit details
    Browse the repository at this point in the history