-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New body scrollbar style option #248
Conversation
This reverts commit b02a186.
078692d
to
d83d869
Compare
d83d869
to
8d77f69
Compare
It seems like the body_scrollbar:
overlay: false
stable: false
|
* Revert "Overlay body scrollbar in all browsers (next-theme#246)" This reverts commit b02a186.
A new CSS property |
Update: To beautify scrollbar: https://segmentfault.com/a/1190000042323523/en |
Reverts #246
PR Checklist
PR Type
What is the current behavior?
I do apologize that I did not realize using
--width
for bothmargin
andwidth
inmain-container
, will make it necessary to set--width
instead ofwidth
everytime we want to change the width of the related elements. In my recent tests, it HAS caused visible problems which did not mentioned in #246, and increases the difficulty of the development in the future.What is the new behavior?
Users needing this functionality should
use the original method mentioned in #176 (comment) , which is editing their custom style file to apply these rules:set the optionbody_scrollbar.overlay
totrue
to place the scrollbar on top of the content.NexT will not apply these rules by default for problems like #246 (comment) .
(Current Status: Option Added, PR Renamed) I think it is better to make the code above an option exists in NexT. Will try to make commits for it and rename this PR if no one complaints.
The new
stable
option only reflects tooverflow-y: scroll
at the moment. Its name and behavior may be changed in later commits, if someone has a better suggestion.How to use?
In NexT
_config.yml
: