Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the nav bar of tabs with long content stick to the top #361

Merged
merged 4 commits into from
Sep 2, 2021
Merged

Make the nav bar of tabs with long content stick to the top #361

merged 4 commits into from
Sep 2, 2021

Conversation

stevenjoezhang
Copy link
Member

@stevenjoezhang stevenjoezhang commented Aug 30, 2021 •
edited

PR Checklist

  • The commit message follows guidelines for NexT.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

Issue resolved: theme-next/hexo-theme-next#958

What is the new behavior?

  • Link to demo site with this changes:
  • Screenshots with this changes:

How to use?

In NexT _config.yml:

tabs:
  sticky: true

@github-actions github-actions bot added the CSS label Aug 30, 2021
This was referenced Aug 30, 2021
Open
Closed
@stevenjoezhang stevenjoezhang changed the title Make tabs with long contents floating on the top Make the nav bar of tabs with long content stick to the top Aug 30, 2021
@stevenjoezhang stevenjoezhang marked this pull request as ready for review August 30, 2021 12:31
@coveralls
Copy link

coveralls commented Aug 31, 2021 •
edited

Pull Request Test Coverage Report for Build 1184356648

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.468%
Totals Coverage Status
Change from base Build 1181126387: 0.0%
Covered Lines: 138
Relevant Lines: 141
💛 - Coveralls

@stevenjoezhang stevenjoezhang added this to the 8.8.0 milestone Sep 1, 2021
@stevenjoezhang stevenjoezhang merged commit 6104854 into master Sep 2, 2021
lingyf pushed a commit to lingyf/hexo-theme-next that referenced this pull request Jan 27, 2022
@stevenjoezhang
Make the nav bar of tabs stick to the top (next-theme#361)
c52c97f
ljcbaby pushed a commit to ljcbaby/hexo-theme-next that referenced this pull request Feb 7, 2022
@stevenjoezhang @ljcbaby
Make the nav bar of tabs stick to the top (next-theme#361)
d1a8994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Configurations CSS ⭐ Feature 🎯 Roadmap
Projects
None yet
Milestone
8.8.0
Development

Successfully merging this pull request may close these issues.

Make tabs with long contents floating on the top
2 participants
@stevenjoezhang @coveralls