Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate DOM reflow with wrapTableWithBox #583

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Conversation

stevenjoezhang
Copy link
Member

PR Checklist

  • The commit message follows guidelines for NexT.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Documentation.
  • Translation.
  • Other... Please describe:

There is a huge DOM reflow before and after the execution of wrapTableWithBox
This problem could be reproduced when the network connection is slow

截屏2022-10-24 14 57 38

What is the current behavior?

Issue resolved:

What is the new behavior?

  • Link to demo site with this changes:
  • Screenshots with this changes:

How to use?

In NexT _config.yml:

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3310673077

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.614%

Totals Coverage Status
Change from base Build 3297764706: 0.0%
Covered Lines: 394
Relevant Lines: 399

💛 - Coveralls

@stevenjoezhang stevenjoezhang requested a review from a team October 24, 2022 07:06
@stevenjoezhang stevenjoezhang changed the title Reduce DOM reflow with wrapTableWithBox Mitigate DOM reflow with wrapTableWithBox Oct 24, 2022
@stevenjoezhang stevenjoezhang merged commit c85cbe7 into master Oct 24, 2022
@stevenjoezhang stevenjoezhang deleted the dom-reflow branch October 24, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants