Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag plugin documentation for Wavedrom. #101

Merged
merged 6 commits into from
Jun 4, 2023

Conversation

r12f
Copy link
Contributor

@r12f r12f commented May 19, 2023

This change adds documentation for next theme wavedrom tag plugin. It contains the syntax, configuration and example on how to use it.

@r12f
Copy link
Contributor Author

r12f commented May 19, 2023

workflow fails, but doesn't look like related to this change. Something in the test infra might need to be updated:

image

or

~~~markdown
```wavedrom
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that wavedrom does not support this syntax

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch! You are right! I debugged a bit more. Although the hexo tag plugin doc mentioned the backtick code block. But the rendering doesn't really process them with tag extends. Only the swigs will be processed. Let me update the docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc is updated now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is also updated.

@stevenjoezhang
Copy link
Member

workflow fails because the hexo-theme-next used in this repository does not support waveform. We will release a new version next month and merge it.

@stevenjoezhang stevenjoezhang merged commit 1ba5803 into next-theme:master Jun 4, 2023
6 checks passed
@r12f
Copy link
Contributor Author

r12f commented Jun 4, 2023

woot! thanks!

@r12f r12f deleted the dev branch June 4, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants