Use getSession's status within auth and account layouts to render/re-direct #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we visit the settings page https://demo.nextacular.co/account/settings and hit refresh/reload, we end up on the https://demo.nextacular.co/account page. This happens because on the first render of the AccountLayout, the
getSession()
's data object is not ready and the user gets incorrectly re-directed to/auth/login
. Within the AuthLayout, thegetSession()->data
is checked again, it is found to be valid and then the user is re-directed tohttps://demo.nextacular.co/account/
.This pull-request attempts to fix the issue by waiting until getSession returns a valid data and this is checked using the status object returned by getSession() instead of the data object. This also fixes #28 and #20
Please note: Since there are no existing test cases, I couldn't test these changes on the nextacular demo site but I did test it out on the code base for my personal project. I would be happy to revise the changes if required.